From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH] net/e1000: do not error out if rx_drop_en is
	set
Date: Wed, 26 Sep 2018 11:22:54 +0100
Message-ID: <1537957374.8363.4.camel@debian.org>
References: <20180727172607.16890-1-bluca@debian.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: wenzhuo.lu@intel.com, stable@dpdk.org, ferruh.yigit@intel.com
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20180727172607.16890-1-bluca@debian.org>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 2018-07-27 at 18:26 +0100, Luca Boccassi wrote:
> rx_drop_en is an optimization that does nothing on single-queue
> devices like e1000. Do not force applications that do not care to
> select per-devices optimizations flags by returning an error, just
> log it and carry on.
>=20
> Fixes: 805803445a02 ("e1000: support EM devices (also known as
> e1000/e1000e)")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> ---
> =C2=A0drivers/net/e1000/em_rxtx.c | 7 ++++---
> =C2=A01 file changed, 4 insertions(+), 3 deletions(-)

Ping. Any chance this could get a review? Thanks!

--=20
Kind regards,
Luca Boccassi