From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] build: improve error message for missing
	dependency
Date: Thu, 26 Jul 2018 10:05:42 +0200
Message-ID: <1538032.sZLDVcAvc4@xps>
References: <20180720132825.772-1-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id A55CA288C
 for <dev@dpdk.org>; Thu, 26 Jul 2018 10:05:48 +0200 (CEST)
In-Reply-To: <20180720132825.772-1-bruce.richardson@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

20/07/2018 15:28, Bruce Richardson:
> When building a driver or library and a required internal dependency
> is missing, the error message printed was:
> 
>     Tried to get unknown variable "shared_rte_<libname>".
> 
> However, a better way to handle this is to catch the missing variable
> earlier and convert it into a proper message, informing the user
> that the required dependency is missing, and most importantly, what
> library or driver wanted that dependency.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks