From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Boccassi Subject: Re: [PATCH 6/6] net/vdev_netvsc: disable vdev netvsc build in FREEBSD Date: Thu, 27 Sep 2018 14:42:32 +0100 Message-ID: <1538055752.8363.32.camel@debian.org> References: <1538054652-20820-1-git-send-email-agalyax.babu.radhakrishnan@intel.com> <1538054652-20820-7-git-send-email-agalyax.babu.radhakrishnan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: alejandro.lucero@netronome.com, allain.legacy@windriver.com, jasvinder.singh@intel.com, keith.wiles@intel.com, matan@mellanox.com, bruce.richardson@intel.com, reshma.pattan@intel.com To: Agalya Babu RadhaKrishnan , dev@dpdk.org Return-path: Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 2DFFE1B4C6 for ; Thu, 27 Sep 2018 15:42:35 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id l10-v6so2694080wrp.3 for ; Thu, 27 Sep 2018 06:42:35 -0700 (PDT) In-Reply-To: <1538054652-20820-7-git-send-email-agalyax.babu.radhakrishnan@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 2018-09-27 at 14:24 +0100, Agalya Babu RadhaKrishnan wrote: > Disabled vdev_netvsc build in FreeBSD because it is not supported > Added changes to enable vdev_netvsc build if it is Linux OS and > disable in FreeBSD. >=20 > Fixes: 6e8a721044 ("vfio: export functions even when disabled") >=20 > Signed-off-by: Agalya Babu RadhaKrishnan intel.com> > --- Hi, I don't think these "Fixes" lines in this set are correct - for example, the vdev_netvsc pmd only got the Meson file recently, but the mentioned commit was back in 18.05. This would cause this individual patch to be picked for the 18.08.1 stable release, even though it shouldn't as the Meson file would be new in 18.11. Same might be true for the other patches. --=20 Kind regards, Luca Boccassi