From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH 0/4] enable meson support for aesni_gcm,
 aesni_mb, kasumi and zuc
Date: Sun, 30 Sep 2018 11:01:38 +0100
Message-ID: <1538301698.6143.1.camel@debian.org>
References: <1538222461-25597-1-git-send-email-hari.kumarx.vemula@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: bruce.richardson@intel.com, reshma.pattan@intel.com,
 declan.doherty@intel.com, pablo.de.lara.guarch@intel.com
To: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com
 [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id A3F46569B
 for <dev@dpdk.org>; Sun, 30 Sep 2018 12:01:40 +0200 (CEST)
Received: by mail-wm1-f66.google.com with SMTP id b19-v6so5921088wme.3
 for <dev@dpdk.org>; Sun, 30 Sep 2018 03:01:40 -0700 (PDT)
In-Reply-To: <1538222461-25597-1-git-send-email-hari.kumarx.vemula@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sat, 2018-09-29 at 13:00 +0100, Hari Kumar Vemula wrote:
> 1/4: enablement of aesni_gcm pmd in meson
> 2/4: enablement of aesni_mb pmd in meson
> 3/4: enablement of kasumi pmd enable in meson
> 4/4: enablement of zuc pmd enable in meson
>=20
> Hari Kumar Vemula (4):
> =C2=A0 driver/crypto: enable meson support for the aesni gcm
> =C2=A0 drivers/crypto: enable meson support for the aesni mb
> =C2=A0 drivers/crypto: enable meson support for the kasumi
> =C2=A0 drivers/crypto: enable meson support for the zuc
>=20
> =C2=A0drivers/crypto/aesni_gcm/meson.build | 17 +++++++++++++++++
> =C2=A0drivers/crypto/aesni_mb/meson.build=C2=A0=C2=A0| 16 +++++++++++++++=
+
> =C2=A0drivers/crypto/kasumi/meson.build=C2=A0=C2=A0=C2=A0=C2=A0| 18 +++++=
+++++++++++++
> =C2=A0drivers/crypto/meson.build=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2=A04 ++--
> =C2=A0drivers/crypto/zuc/meson.build=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0| 18 ++++++++++++++++++
> =C2=A0meson_options.txt=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=
=C2=A0=C2=A06 ++++++
> =C2=A06 files changed, 77 insertions(+), 2 deletions(-)
> =C2=A0create mode 100644 drivers/crypto/aesni_gcm/meson.build
> =C2=A0create mode 100644 drivers/crypto/aesni_mb/meson.build
> =C2=A0create mode 100644 drivers/crypto/kasumi/meson.build
> =C2=A0create mode 100644 drivers/crypto/zuc/meson.build

Hi,

With Meson we want to reduce the large number of build-time options.
For dependencies, I don't think it's necessary to have a separate
option to pass the library path.

The preferred option would be for the dependency to have a pkg-config
file which sets the necessary flags. If that's not installed in the
standard path, the PKG_CONFIG_PATH environment variable can be set to
add custom paths.

If a dependency does not have a pkg-config file (if you control it
would be a good time to add it :-) ), then you can set the path to the
shared object with something like: LD_FLAGS=3D-L/path/to/lib/ and Meson
will use that automatically (and CFLAGS=3D-I/path/to/headers/ if
necessary as well).

--=20
Kind regards,
Luca Boccassi