From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v4] lib/librte_meter: add meter configuration
	profile
Date: Mon, 19 Feb 2018 22:12:15 +0100
Message-ID: <1538626.jQhP2Ch2ao@xps>
References: <20180108100044.38368-2-jasvinder.singh@intel.com>
 <20180108154356.44765-1-jasvinder.singh@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Jasvinder Singh <jasvinder.singh@intel.com>, cristian.dumitrescu@intel.com
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 649667D30
 for <dev@dpdk.org>; Mon, 19 Feb 2018 22:12:35 +0100 (CET)
In-Reply-To: <20180108154356.44765-1-jasvinder.singh@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

08/01/2018 16:43, Jasvinder Singh:
> From: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> 
> This patch adds support for meter configuration profiles.
> Benefits: simplified configuration procedure, improved performance.
> 
> Q1: What is the configuration profile and why does it make sense?
> A1: The configuration profile represents the set of configuration
>     parameters for a given meter object, such as the rates and sizes for
>     the token buckets. The configuration profile concept makes sense when
>     many meter objects share the same configuration, which is the typical
>     usage model: thousands of traffic flows are each individually metered
>     according to just a few service levels (i.e. profiles).
> 
> Q2: How is the configuration profile improving the performance?
> A2: The performance improvement is achieved by reducing the memory
>     footprint of a meter object, which results in better cache utilization
>     for the typical case when large arrays of meter objects are used. The
>     internal data structures stored for each meter object contain:
>        a) Constant fields: Low level translation of the configuration
>           parameters that does not change post-configuration. This is
>           really duplicated for all meters that use the same
>           configuration. This is the configuration profile data that is
>           moved away from the meter object. Current size (implementation
>           dependent): srTCM = 32 bytes, trTCM = 32 bytes.
>        b) Variable fields: Time stamps and running counters that change
>           during the on-going traffic metering process. Current size
>           (implementation dependant): srTCM = 24 bytes, trTCM = 32 bytes.
>           Therefore, by moving the constant fields to a separate profile
>           data structure shared by all the meters with the same
>           configuration, the size of the meter object is reduced by ~50%.
> 
> Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>

Applied for 18.05 (was postponed to preserve 18.02 ABI), thanks.