From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Rybchenko Subject: [PATCH 2/2] net/sfc: allow to query RSS key and HF when RSS is disabled Date: Thu, 11 Oct 2018 15:51:13 +0100 Message-ID: <1539269473-21739-2-git-send-email-arybchenko@solarflare.com> References: <1539269473-21739-1-git-send-email-arybchenko@solarflare.com> Mime-Version: 1.0 Content-Type: text/plain Cc: Ivan Malov , To: Return-path: In-Reply-To: <1539269473-21739-1-git-send-email-arybchenko@solarflare.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Ivan Malov If global RSS is not enabled in the multiqueue mode setting, it will not be possible to change RSS configuration. However, querying default RSS settings should be possible in any case since it may be needed by RTE flow API users to find out what RSS settings will be used by default for a flow rule with RSS action if custom RSS key and hash function choice are not specified. Fixes: 63ab5e0c8fda ("net/sfc: use zero RSS channels as disabled RSS indicator") Cc: stable@dpdk.org Signed-off-by: Ivan Malov Signed-off-by: Andrew Rybchenko --- drivers/net/sfc/sfc_ethdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/sfc/sfc_ethdev.c b/drivers/net/sfc/sfc_ethdev.c index 00f088013..b2e17f26e 100644 --- a/drivers/net/sfc/sfc_ethdev.c +++ b/drivers/net/sfc/sfc_ethdev.c @@ -1358,9 +1358,6 @@ sfc_dev_rss_hash_conf_get(struct rte_eth_dev *dev, if (rss->context_type != EFX_RX_SCALE_EXCLUSIVE) return -ENOTSUP; - if (rss->channels == 0) - return -EINVAL; - sfc_adapter_lock(sa); /* -- 2.17.1