From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v3 2/4] devargs: simplify parameters of
	removal function
Date: Mon, 01 Oct 2018 21:47:54 +0200
Message-ID: <15400060.KEnbAWTMbX@xps>
References: <20180907222727.20521-1-thomas@monjalon.net>
 <20180928162144.1972-3-thomas@monjalon.net>
 <e79c873f-19fb-9d07-964b-f1921e2f8e9e@solarflare.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, gaetan.rivet@6wind.com, ophirmu@mellanox.com,
 qi.z.zhang@intel.com, ferruh.yigit@intel.com, ktraynor@redhat.com
To: Andrew Rybchenko <arybchenko@solarflare.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 93CE058C4
 for <dev@dpdk.org>; Mon,  1 Oct 2018 21:48:00 +0200 (CEST)
In-Reply-To: <e79c873f-19fb-9d07-964b-f1921e2f8e9e@solarflare.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

01/10/2018 13:25, Andrew Rybchenko:
> On 9/28/18 7:21 PM, Thomas Monjalon wrote:
> > The function rte_devargs_remove(), which is intended to be internal,
> > can take a devargs structure as argument.
> > The matching is still using string comparison of bus name and
> > device name.
> > It is simpler and may allow a different devargs matching in future.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> 
> Reviewed-by: Andrew Rybchenko <arybchenko@solarflare.com>
> 
> What about release notes? It is API change, yes, experimental, but still.

Yes, you're right.
Will fix in v4, thanks.