From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH v2] build: add meson.build for kni kernel
 module
Date: Mon, 29 Oct 2018 15:33:47 +0000
Message-ID: <1540827227.29722.8.camel@debian.org>
References: <1539364001.8721.45.camel@debian.org>
 <CGME20181029140903eucas1p1021673ecc6c9d40c31dd21ca52dbb114@eucas1p1.samsung.com>
 <6d16dc9e-c2f5-ba4b-eeb5-a9cdd8ac75bc@samsung.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
To: Ilya Maximets <i.maximets@samsung.com>, dev@dpdk.org, Bruce Richardson
 <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com
 [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 6B06C1E2F
 for <dev@dpdk.org>; Mon, 29 Oct 2018 16:33:50 +0100 (CET)
Received: by mail-wm1-f66.google.com with SMTP id b203-v6so8416992wme.5
 for <dev@dpdk.org>; Mon, 29 Oct 2018 08:33:50 -0700 (PDT)
In-Reply-To: <6d16dc9e-c2f5-ba4b-eeb5-a9cdd8ac75bc@samsung.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, 2018-10-29 at 17:09 +0300, Ilya Maximets wrote:
> > On Fri, 2018-10-12 at 17:29 +0100, Bruce Richardson wrote:
> > > On Fri, Oct 12, 2018 at 04:12:21PM +0100, Luca Boccassi wrote:
> > > > A Kbuild is also included to allow users to use DKMS natively
> > > > without
> > > > additional code.
> > > >=20
> > > > Signed-off-by: Luca Boccassi <bluca at debian.org>
> > > > ---
> > > > v2: add local directory to -I and build sources list
> > > > recursively to
> > > > =C2=A0=C2=A0=C2=A0=C2=A0fix build on Fedora
> > > >=20
> > >=20
> > > Yep, now seems to build for me on Fedora. One minor suggestion is
> > > to
> > > look
> > > to use the "console" keyword on the custom_target if possible. It
> > > should
> > > help prevent noticable stalls as make runs in the background.
> > > [Unfortunately, it's meson 0.48 onward only, so if conditionals
> > > are
> > > needed,
> > > just ignore this suggestion]
> >=20
> > Good idea, I just with 0.48, 0.47 and 0.41 and in all cases there
> > are
> > no complaints or errors, it's simply ignored in the older versions.
>=20
> Hmm.
> I have following on my Ubuntu 18.04 with dpdk v18.11-rc1:
>=20
> $ meson --version
> 0.45.1
>=20
> $ meson build
> <...>
> kernel/linux/kni/meson.build:16: WARNING: Passed invalid keyword
> argument "console".
> WARNING: This will become a hard error in the future.
> WARNING: Unknown keyword arguments in target rte_kni: console
> <...>
>=20
> It builds, but prints above warning.
>=20
> Best regards, Ilya Maximets.

Interesting, wonder why I didn't see that on 0.41! Anyway those
warnings are fine to ignore, especially in this case.

--=20
Kind regards,
Luca Boccassi