From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH] enic: state change from link-down to link-up
	not recognized
Date: Wed, 30 Mar 2016 19:35:01 +0200
Message-ID: <1540849.gS1UoX4J3q@xps13>
References: <1458953117-13817-1-git-send-email-johndale@cisco.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: John Daley <johndale@cisco.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45])
 by dpdk.org (Postfix) with ESMTP id 57571952
 for <dev@dpdk.org>; Wed, 30 Mar 2016 19:36:54 +0200 (CEST)
Received: by mail-wm0-f45.google.com with SMTP id 127so106153259wmu.1
 for <dev@dpdk.org>; Wed, 30 Mar 2016 10:36:54 -0700 (PDT)
In-Reply-To: <1458953117-13817-1-git-send-email-johndale@cisco.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-25 17:45, John Daley:
> When the enic was disabled, link notification was correctly disabled
> in the NIC but the software indicator that it was disabled was not
> updated (vdev->notify_pa not set to 0). When the link came back up,
> enic did not re-enable notification in the NIC.
> 
> This affected bonding when a enic slave device link bounced.
> 
> The fix is to unconditionally enable notification when the enic is
> enabled.
> 
> Fixes: 9913fbb91df0 ("enic/base: common code")
> 
> Signed-off-by: John Daley <johndale@cisco.com>
> Reviewed-by: Nelson Escobar <neescoba@cisco.com>

Applied, thanks