From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCHv3 0/5] ACL library Date: Sat, 14 Jun 2014 01:38:11 +0200 Message-ID: <1541041.MVudaz1CFn@xps13> References: <1402658814-21881-1-git-send-email-konstantin.ananyev@intel.com> <3012262.OhlkyXXJnt@xps13> <2601191342CEEE43887BDE71AB9772580EFB6982@IRSMSX105.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: "Ananyev, Konstantin" Return-path: In-Reply-To: <2601191342CEEE43887BDE71AB9772580EFB6982-kPTMFJFq+rEu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-06-13 12:02, Ananyev, Konstantin: > 2014-06-13 13:56, Thomas Monjalon: > > > Konstantin Ananyev (5): > > > Add ACL library (librte_acl) into DPDK > > > acl: update UT to reflect latest changes in the librte_acl > > > acl: New test-acl application > > > acl: New sample l3fwd-acl > > > acl: add doxygen configuration and start page > > > > > > v2 fixes: > > > * Fixed several checkpatch.pl issues > > > * Added doxygen related changes > > > > > > v3 fixes: > > > * Fixed even more checkpatch.pl issues > > > > Sorry to bother you but after checking v3, > > > > I think these errors should be avoided: > > ERROR: do not use assignment in if condition > > ERROR: return is not a function, parentheses are not required > > These changes would require a lot of changes inside ACL library. > As I said in cover letter, ACL library was part of IPL code for a while > (nearly a year). > I don't really want to make significant changes in it just before the > release without really good reason - bugs found. I've made the code style changes, move some configuration lines and added to BSD build (not tested). As it was previously acked and tested, it is now applied for version 1.7.0. Thanks -- Thomas