From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Boccassi Subject: Re: [PATCH v3 1/2] net/ixgbe: fix x550 code to handle unidentified PHY Date: Wed, 07 Nov 2018 12:55:08 +0000 Message-ID: <1541595308.31208.0.camel@debian.org> References: <20180815170932.23536-1-bluca@debian.org> <20181102151848.18024-1-bluca@debian.org> <039ED4275CED7440929022BC67E70611532DF9A9@SHSMSX103.ccr.corp.intel.com> <494f9ba9-cadc-aa36-2b17-42890dbe5c74@gmail.com> <039ED4275CED7440929022BC67E70611532E07D1@SHSMSX103.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: "Lu, Wenzhuo" , "Ananyev, Konstantin" , "stable@dpdk.org" To: "Zhang, Qi Z" , Chas Williams <3chas3@gmail.com>, "dev@dpdk.org" Return-path: In-Reply-To: <039ED4275CED7440929022BC67E70611532E07D1@SHSMSX103.ccr.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, 2018-11-06 at 23:31 +0000, Zhang, Qi Z wrote: > > -----Original Message----- > > From: Chas Williams [mailto:3chas3@gmail.com] > > Sent: Monday, November 5, 2018 11:19 AM > > To: Zhang, Qi Z ; Luca Boccassi > .org>; > > dev@dpdk.org > > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > > ; stable@dpdk.org > > Subject: Re: [PATCH v3 1/2] net/ixgbe: fix x550 code to handle > > unidentified > > PHY > >=20 > >=20 > >=20 > > On 11/05/2018 12:41 PM, Zhang, Qi Z wrote: > > >=20 > > >=20 > > > > -----Original Message----- > > > > From: Luca Boccassi [mailto:bluca@debian.org] > > > > Sent: Friday, November 2, 2018 8:19 AM > > > > To: dev@dpdk.org > > > > Cc: Lu, Wenzhuo ; Ananyev, Konstantin > > > > ; Zhang, Qi Z > > > om>; > > > > 3chas3@gmail.com; Luca Boccassi ; stable@dpdk > > > > .org > > > > Subject: [PATCH v3 1/2] net/ixgbe: fix x550 code to handle > > > > unidentified PHY > > > >=20 > > > > ixgbe_identify_sfp_module_X550em() was missing the code to > > > > handle > > > > unidentified PHY that has been there in 82599 so it was not > > > > able to > > > > complete initialization of ixgbe sequence if no sfp plugged in. > > > > Port it over to return an appropriate type and complete init > > > > sequence > > > > properly. > > > >=20 > > > > Fixes: d2e72774e58c ("ixgbe/base: support X550") > > > > Cc: stable@dpdk.org > > > >=20 > > > > Signed-off-by: Luca Boccassi > > > > --- > > > > v2: refresh to remove merge conflict with master > > > > v3: coalesce fix into ixgbe_identify_sfp_module_X550em to avoid > > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0code duplication, improve comment > > > >=20 > > > > =C2=A0 drivers/net/ixgbe/base/ixgbe_x550.c | 6 ++++++ > > > > =C2=A0 1 file changed, 6 insertions(+) > > > >=20 > > > > diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c > > > > b/drivers/net/ixgbe/base/ixgbe_x550.c > > > > index f7b98af52..a88d5c86a 100644 > > > > --- a/drivers/net/ixgbe/base/ixgbe_x550.c > > > > +++ b/drivers/net/ixgbe/base/ixgbe_x550.c > > > > @@ -1561,6 +1561,12 @@ s32 > >=20 > > ixgbe_identify_sfp_module_X550em(struct > > > > ixgbe_hw *hw) > > > >=20 > > > > =C2=A0=C2=A0 status =3D ixgbe_identify_module_generic(hw); > > > >=20 > > > > + /* Set PHY type none if no PHY detected to allow init > > > > without SFP */ > > > > + if (hw->phy.type =3D=3D ixgbe_phy_unknown) { > > > > + hw->phy.type =3D ixgbe_phy_none; > > >=20 > > > Set PHY type to none for a device that does have PHY looks weird. > > > does ixgeb_phy_generic works here? > >=20 > > Yes, it does seem strange but that's what > > ixgbe_identify_sfp_module_generic > > seems to do: > >=20 > > err_read_i2c_eeprom: > > hw->phy.sfp_type =3D ixgbe_sfp_type_not_present; > > if (hw->phy.type !=3D ixgbe_phy_nl) { > > hw->phy.id =3D 0; > > hw->phy.type =3D ixgbe_phy_unknown; > > } > >=20 > > The QSFP version a little more forceful: > >=20 > > err_read_i2c_eeprom: > > hw->phy.sfp_type =3D ixgbe_sfp_type_not_present; > > hw->phy.id =3D 0; > > hw->phy.type =3D ixgbe_phy_unknown; > >=20 > > If we go forward without setting the phy_type to none, we will > > eventually run > > into issues calling other phy routines. > >=20 > > So should a lack of SFP, reset the PHY type? It's hazy because the > > difference > > between PHY and SFP isn't that clear to me here. >=20 > I'm not sure that's the same case:). > Just feel that it's better to handle ixgbe_phy_unknown directly for > some device id as a special case than just replace it to > ixgbe_phy_none to cheat the check path, since that rely on we never > change the way to handle ixgbe_phy_none. >=20 > So still have the question? > What is the failure if you go with ixgbe_phy_unknown? > Is that possible to work around this like > if (phy_type =3D=3D ixgbe_phy_unknown && dev_id =3D=3D xxxx) > ... Hi, Thanks for having a look at this again. If you could please see the other answer, from myself, I've quoted the exact error we see and the issue it causes. --=20 Kind regards, Luca Boccassi