From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] eal_pci: Fix max_vfs missing for none igb_uio driver Date: Fri, 13 Feb 2015 14:49:23 +0100 Message-ID: <1541600.e9txtCqPjk@xps13> References: <1423653001-11660-1-git-send-email-michael.qiu@intel.com> <1423661155-16645-1-git-send-email-michael.qiu@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Michael Qiu Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" > > max_vfs will only be created by igb_uio driver, for other > > drivers like vfio or pci_uio_generic, max_vfs will miss. > > > > But sriov_numvfs is not driver related, just get the vf numbers > > from that field. > > > > Signed-off-by: Michael Qiu > > I can see a different solution : maybe faking a sriov_numvfs parameter from > igb_uio for kernels that don't have it and doing nothing for kernels that > already provide sriov_numvfs. > But your solution is more straightforward (and we don't need to update > documentation and/or existing scripts afaik). > > Acked-by: David Marchand Applied, thanks