From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v5 2/4] ethdev: introduce new tunnel VXLAN-GPE
Date: Tue, 17 Apr 2018 22:56:52 +0200
Message-ID: <1541697.oJ8yBXImSN@xps>
References: <20180417150404.160990-1-xuemingl@mellanox.com>
 <20180417150404.160990-3-xuemingl@mellanox.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, Wenzhuo Lu <wenzhuo.lu@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
 Shahaf Shuler <shahafs@mellanox.com>, Olivier Matz <olivier.matz@6wind.com>
To: Xueming Li <xuemingl@mellanox.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com
 [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id C6C62AA97
 for <dev@dpdk.org>; Tue, 17 Apr 2018 22:56:55 +0200 (CEST)
In-Reply-To: <20180417150404.160990-3-xuemingl@mellanox.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

17/04/2018 17:04, Xueming Li:
> +struct rte_flow_item_vxlan_gpe {
> +	uint8_t flags; /**< Normally 0x0c (I and P flags). */
> +	uint8_t rsvd0[2]; /**< Reserved, normally 0x0000. */
> +	uint8_t protocol; /**< Protocol type. */
> +	uint8_t vni[3]; /**< VXLAN identifier. */
> +	uint8_t rsvd1; /**< Reserved, normally 0x00. */
> +};

These comments are not aligned.


> +struct vxlan_gpe_hdr {
> +	uint8_t vx_flags;	/**< flag (8). */
> +	uint8_t reserved[2];	/**< Reserved (16). */
> +	uint8_t proto;		/**< next-protocol (8). */
> +	uint32_t vx_vni;	/**< VNI (24) + Reserved (8). */
> +} __attribute__((__packed__));

Alignment must be done with spaces.