From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] pci: fix non-Intel devices probing
Date: Mon, 16 Sep 2013 22:38:47 +0200
Message-ID: <1541839.XYEVK3QFDL@x220>
References: <1379363340-20870-1-git-send-email-thomas.monjalon@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
To: dev-VfR2kkLFssw@public.gmane.org
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1379363340-20870-1-git-send-email-thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

> There is no need to check for bars mapping, especially BAR0 is not required.
> If bars mapping failed, then pci_uio_map_resource will fail and we won't
> reach this check. So get rid of BAR0 check.
> Besides, pci_uio_map_resource should only be called for Intel devices.
> The flag RTE_PCI_DRV_NEED_IGB_UIO is set for all Intel devices, even when
> RTE_EAL_UNBIND_PORTS is disabled.

Addendum:
This patch is needed to run virtio-net-pmd and vmxnet3-usermap with DPDK 1.4.