From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH] drivers/net: set close behaviour flag at
	probing
Date: Mon, 12 Nov 2018 09:42:49 +0000
Message-ID: <1542015769.11515.0.camel@debian.org>
References: <20181111224611.19234-1-thomas@monjalon.net>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: ferruh.yigit@intel.com, ophirmu@mellanox.com, mk@semihalf.com
To: Thomas Monjalon <thomas@monjalon.net>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com
 [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 714BD201
 for <dev@dpdk.org>; Mon, 12 Nov 2018 10:42:56 +0100 (CET)
Received: by mail-wr1-f67.google.com with SMTP id u5-v6so3240329wrn.9
 for <dev@dpdk.org>; Mon, 12 Nov 2018 01:42:56 -0800 (PST)
In-Reply-To: <20181111224611.19234-1-thomas@monjalon.net>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sun, 2018-11-11 at 23:46 +0100, Thomas Monjalon wrote:
> The ethdev flag RTE_ETH_DEV_CLOSE_REMOVE is set for drivers
> having migrated to the new behaviour of rte_eth_dev_close().
>=20
> As any other flag, it can be useful to know about its value
> as soon as the port is probed.
> Unfortunately, it was set inside the close operation,
> just before being erased by memset() in rte_eth_dev_release_port().
> The flag assignment is moved to the probing stage, so it can
> be checked by the application in order to anticipate the behaviour.
>=20
> Fixes: 42603bbdb58e ("net/mlx5: release port on close")
> Cc: ophirmu@mellanox.com
> Fixes: 6c99085d972b ("net/vmxnet3: fix hot-unplug")
> Cc: bluca@debian.org
> Fixes: 4d7877fde2ef ("net/ena: remove resources when port is being
> closed")
> Cc: mk@semihalf.com
>=20
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> =C2=A0drivers/net/ena/ena_ethdev.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0| 11 ++++++-----
> =C2=A0drivers/net/mlx5/mlx5.c=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2=A07 ++-----
> =C2=A0drivers/net/vmxnet3/vmxnet3_ethdev.c |=C2=A0=C2=A09 +++------
> =C2=A03 files changed, 11 insertions(+), 16 deletions(-)

Acked-by: Luca Boccassi <bluca@debian.org>

--=20
Kind regards,
Luca Boccassi