From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH 1/2] build: avoid non supported -march on ppc
	(meson)
Date: Wed, 14 Nov 2018 11:39:38 +0000
Message-ID: <1542195578.11515.9.camel@debian.org>
References: <20181114113453.24852-1-christian.ehrhardt@canonical.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
To: Christian Ehrhardt <christian.ehrhardt@canonical.com>, dev <dev@dpdk.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com
 [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 90A4A5F22
 for <dev@dpdk.org>; Wed, 14 Nov 2018 12:39:41 +0100 (CET)
Received: by mail-wm1-f65.google.com with SMTP id p2-v6so14375405wmc.2
 for <dev@dpdk.org>; Wed, 14 Nov 2018 03:39:41 -0800 (PST)
In-Reply-To: <20181114113453.24852-1-christian.ehrhardt@canonical.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, 2018-11-14 at 12:34 +0100, Christian Ehrhardt wrote:
> So far only if machine was "native" it did use the re-direction to
> not set -march on ppc64 (where -march is not supported).
> We have to use mcpu/mtune in any case on ppc for whatever someone
> using
> the build system defines as machine.
>=20
> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
> ---
> =C2=A0config/meson.build | 5 +++--
> =C2=A01 file changed, 3 insertions(+), 2 deletions(-)
>=20
> diff --git a/config/meson.build b/config/meson.build
> index 0b710b795..1af305f46 100644
> --- a/config/meson.build
> +++ b/config/meson.build
> @@ -9,8 +9,9 @@ else
> =C2=A0endif
> =C2=A0dpdk_conf.set('RTE_MACHINE', machine)
> =C2=A0machine_args =3D []
> -# ppc64 does not support -march=3Dnative
> -if host_machine.cpu_family().startswith('ppc') and machine =3D=3D
> 'native'
> +
> +# ppc64 does not support -march=3D at all, use -mcpu and -mtune for
> that
> +if host_machine.cpu_family().startswith('ppc')
> =C2=A0	machine_args +=3D '-mcpu=3D' + machine
> =C2=A0	machine_args +=3D '-mtune=3D' + machine
> =C2=A0else

Acked-by: Luca Boccassi <bluca@debian.org>

--=20
Kind regards,
Luca Boccassi