From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Boccassi Subject: Re: [PATCH] build: document that Meson < 0.45 will fail to list private deps Date: Fri, 16 Nov 2018 10:55:41 +0000 Message-ID: <1542365741.11515.27.camel@debian.org> References: <20181115182628.8114-1-bluca@debian.org> <20181116102632.GC3144@bricha3-MOBL.ger.corp.intel.com> <1542365567.11515.26.camel@debian.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org, thomas@monjalon.net To: Bruce Richardson Return-path: Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 784542BB1 for ; Fri, 16 Nov 2018 11:55:43 +0100 (CET) Received: by mail-wr1-f67.google.com with SMTP id l9so11526063wrt.13 for ; Fri, 16 Nov 2018 02:55:43 -0800 (PST) In-Reply-To: <1542365567.11515.26.camel@debian.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 2018-11-16 at 10:52 +0000, Luca Boccassi wrote: > On Fri, 2018-11-16 at 10:26 +0000, Bruce Richardson wrote: > > On Thu, Nov 15, 2018 at 06:26:28PM +0000, Luca Boccassi wrote: > > > Meson can generate the list of private dependencies of libraries > > > automatically for the pkgconfig file only since version 0.45.0. > > >=20 > > > Signed-off-by: Luca Boccassi > > > --- > > > =C2=A0doc/build-sdk-meson.txt | 6 ++++++ > > > =C2=A01 file changed, 6 insertions(+) > > >=20 > > > diff --git a/doc/build-sdk-meson.txt b/doc/build-sdk-meson.txt > > > index 508e2cb64..229398bb0 100644 > > > --- a/doc/build-sdk-meson.txt > > > +++ b/doc/build-sdk-meson.txt > > > @@ -203,3 +203,9 @@ From examples/helloworld/Makefile:: > > > =C2=A0 > > > =C2=A0 build: > > > =C2=A0 @mkdir -p $@ > > > + > > > +NOTE: for --static builds, DPDK needs to be built with Meson >=3D > > > 0.45 in order to > > > +fully generate the list of private dependencies. If DPDK is > > > built > > > with an older > > > +version of Meson, it might be necessary to manually specify > > > dependencies of DPDK > > > +PMDs/libraries, for example -lmlx5 -lmnl for librte-pmd-mlx5, or > > > the static link > > > +step might fail. > >=20 > > Thinking about it more, this doesn't seem to actually be the root- > > cause of > > the reported problem. You said in the other thread that you > > reproduced the > > problem with v0.45.2 which is >=3D 0.45 > >=20 > > /Bruce >=20 > I think the documentation linked there is wrong - looking at the > release notes in the repository, it's 0.46 that mentions that new > feature, not 0.45: >=20 > https://github.com/mesonbuild/meson/blob/master/docs/markdown/Release > -notes-for-0.46.0.md#improved-generation-of-pkg-config-files-for- > static-only-libraries >=20 > I'll check if I can repro with 0.46 to confirm Yes I can confirm that it's 0.46 that actually fixes the issue, so I'll send a v2 with the updated version. --=20 Kind regards, Luca Boccassi