From mboxrd@z Thu Jan  1 00:00:00 1970
From: Mohammed Gamal <mgamal@redhat.com>
Subject: Re: [PATCH] kni: Fix build on RHEL 8
Date: Tue, 27 Nov 2018 12:13:22 +0100
Message-ID: <1543317202.5400.13.camel@redhat.com>
References: <1543265151-14617-1-git-send-email-mgamal@redhat.com>
 <26d50d0f-8eb0-608f-9aed-5f3b39a85ff8@intel.com>
Reply-To: mgamal@redhat.com
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
To: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by dpdk.org (Postfix) with ESMTP id BB52F568A
 for <dev@dpdk.org>; Tue, 27 Nov 2018 12:13:25 +0100 (CET)
In-Reply-To: <26d50d0f-8eb0-608f-9aed-5f3b39a85ff8@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 2018-11-27 at 10:55 +0000, Ferruh Yigit wrote:
> On 11/26/2018 8:45 PM, Mohammed Gamal wrote:
> > As RHEL8 beta has been released and is based on recent upstream
> > kernels
> > which don't use ndo_change_mtu_rh74 function. Fix the build so that
> > it
> > doesn't fail because the function is missing
> > 
> > Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
> > ---
> >  kernel/linux/kni/compat.h | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/kernel/linux/kni/compat.h b/kernel/linux/kni/compat.h
> > index 5aadebb..bc81d0c 100644
> > --- a/kernel/linux/kni/compat.h
> > +++ b/kernel/linux/kni/compat.h
> > @@ -103,7 +103,8 @@
> >  #endif
> >  
> >  #if (defined(RHEL_RELEASE_CODE) && \
> > -	(RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)))
> > +	(RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)) && \
> > +	(RHEL_RELEASE_CODE < RHEL_RELEASE_VERSION(8, 0)))
> >  #define ndo_change_mtu ndo_change_mtu_rh74
> 
> What RHEL use, can you please confirm it turns back to
> `ndo_change_mtu`, instead
> of something like `ndo_change_mtu_rh8x`?

There are no such functions in the RHEL8 kernel. You may check the
kernel source code from the SRPM available here:
http://ftp.redhat.com/redhat/rhel/rhel-8-beta/baseos/source/Packages/ke
rnel-4.18.0-32.el8.src.rpm

> 
> >  #endif
> >  
> > 
> 
>