From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH] mk: don't install meson.build in usertools
Date: Wed, 28 Nov 2018 10:13:24 +0000
Message-ID: <1543400004.5087.13.camel@debian.org>
References: <f4aeee269d9d83e8e65ea6acd62933da6b31102d.1543347246.git.tredaelli@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
To: Timothy Redaelli <tredaelli@redhat.com>, Thomas Monjalon
 <thomas@monjalon.net>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com
 [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id C474E1B433
 for <dev@dpdk.org>; Wed, 28 Nov 2018 11:13:26 +0100 (CET)
Received: by mail-wm1-f66.google.com with SMTP id a18so1298457wmj.1
 for <dev@dpdk.org>; Wed, 28 Nov 2018 02:13:26 -0800 (PST)
In-Reply-To: <f4aeee269d9d83e8e65ea6acd62933da6b31102d.1543347246.git.tredaelli@redhat.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, 2018-11-27 at 20:35 +0100, Timothy Redaelli wrote:
> In commit 7dd34c71de2a ("usertools: install with meson") meson.build
> was
> added in usertools directory and so it's copied to
> $(datadir)/usertools
> with "make install".
>=20
> This patch avoids to copy meson.build when installing usertools with
> "make install".
>=20
> Signed-off-by: Timothy Redaelli <tredaelli@redhat.com>
> ---
> =C2=A0mk/rte.sdkinstall.mk | 5 +++--
> =C2=A01 file changed, 3 insertions(+), 2 deletions(-)
>=20
> diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk
> index 8296e6dbd..2d34b4e5a 100644
> --- a/mk/rte.sdkinstall.mk
> +++ b/mk/rte.sdkinstall.mk
> @@ -99,8 +99,9 @@ install-runtime:
> =C2=A0		--exclude 'app/cmdline*' --exclude app/test \
> =C2=A0		--exclude app/testacl --exclude app/testpipeline app
> | \
> =C2=A0	=C2=A0=C2=A0=C2=A0=C2=A0tar -xf -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0-C $(DESTDIR)$(bindir) $(TAR_X_FLAGS)
> -	$(Q)$(call rte_mkdir,=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0$(DESTDIR)$(da=
tadir))
> -	$(Q)cp $(CP_FLAGS) $(RTE_SDK)/usertools $(DESTDIR)$(datadir)
> +	$(Q)$(call rte_mkdir,=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0$(DESTDIR)$(da=
tadir)/usertools)
> +	$(Q)tar -cf -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0-C $(RTE_SDK) --exclud=
e meson.build
> usertools | \
> +	=C2=A0=C2=A0=C2=A0=C2=A0tar -xf -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0-C=
 $(DESTDIR)$(datadir)/usertools
> $(TAR_X_FLAGS)
> =C2=A0	$(Q)$(call rte_mkdir,=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0$(DESTDIR=
)$(sbindir))
> =C2=A0	$(Q)$(call
> rte_symlink,=C2=A0=C2=A0=C2=A0=C2=A0$(DESTDIR)$(datadir)/usertools/dpdk-d=
evbind.py, \
> =C2=A0	=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0$(DESTDIR)$(sbindir)/dpdk-
> devbind)

Acked-by: Luca Boccassi <bluca@debian.org>

Should probably add:

Fixes: 7dd34c71de2a ("usertools: install with meson")
Cc: stable@dpdk.org

--=20
Kind regards,
Luca Boccassi