From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH] ip_frag: fix ipv6 when MTU sizes not aligned
 to 8 bytes
Date: Wed, 28 Nov 2018 10:15:03 +0000
Message-ID: <1543400103.5087.14.camel@debian.org>
References: <20181127045613.16437-1-3chas3@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: konstantin.ananyev@intel.com, Chas Williams <chas3@att.com>
To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com
 [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id B009C1D9E
 for <dev@dpdk.org>; Wed, 28 Nov 2018 11:15:05 +0100 (CET)
Received: by mail-wr1-f65.google.com with SMTP id t3so25671058wrr.3
 for <dev@dpdk.org>; Wed, 28 Nov 2018 02:15:05 -0800 (PST)
In-Reply-To: <20181127045613.16437-1-3chas3@gmail.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, 2018-11-26 at 23:56 -0500, Chas Williams wrote:
> From: Chas Williams <chas3@att.com>
>=20
> The same issue was fixed on for the ipv4 version of this routine in
> commit 8d4d3a4f7337 ("ip_frag: handle MTU sizes not aligned to 8
> bytes").
> Briefly, the size of an ipv6 header is always 40 bytes.=C2=A0=C2=A0With a=
n MTU
> of
> 1500, this will never produce a multiple of 8 bytes for the frag_size
> and this routine can never succeed. Since RTE_ASSERTS are disabled by
> default, this failure is tpyically ignored.
>=20
> To fix this, round down to the nearest 8 bytes and use this when
> producing the fragments.
>=20
> Fixes: 0aa31d7a5929 ("ip_frag: add IPv6 fragmentation support")
>=20
> Signed-off-by: Chas Williams <chas3@att.com>
> ---
> =C2=A0lib/librte_ip_frag/rte_ip_frag.h=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=C2=A01 +
> =C2=A0lib/librte_ip_frag/rte_ipv6_fragmentation.c | 18 +++++++++++-------
> =C2=A02 files changed, 12 insertions(+), 7 deletions(-)

Acked-by: Luca Boccassi <bluca@debian.org>

--=20
Kind regards,
Luca Boccassi