From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Marchand Subject: [PATCH 2/2] devtools: drop '+' from the section name Date: Wed, 28 Nov 2018 11:28:53 +0100 Message-ID: <1543400933-1723-2-git-send-email-david.marchand@redhat.com> References: <1543400933-1723-1-git-send-email-david.marchand@redhat.com> Cc: thomas@monjalon.net, echaudro@redhat.com To: nhorman@tuxdriver.com, dev@dpdk.org Return-path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 078BC1B465 for ; Wed, 28 Nov 2018 11:29:28 +0100 (CET) In-Reply-To: <1543400933-1723-1-git-send-email-david.marchand@redhat.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The incriminated commit did relax the condition to catch all sections but dropped the + removal which can trigger false detection of the special EXPERIMENTAL section when adding symbols and the section in the same patch. Fixes: 7281cf520f89 ("devtools: relax rule for identifying symbol section") Signed-off-by: David Marchand --- Used http://patchwork.dpdk.org/patch/48354/ to test. --- devtools/check-symbol-change.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change.sh index 66741be..8b36ccd 100755 --- a/devtools/check-symbol-change.sh +++ b/devtools/check-symbol-change.sh @@ -31,6 +31,7 @@ build_map_changes() # Triggering this rule sets in_sec to 1, which actives the # symbol rule below /^.*{/ { + gsub("+", ""); if (in_map == 1) { sec=$(NF-1); in_sec=1; } -- 1.8.3.1