From mboxrd@z Thu Jan 1 00:00:00 1970 From: Erik Gabriel Carrillo Subject: [PATCH v3] app/eventdev: detect deadlock for timer event producer Date: Mon, 3 Dec 2018 11:48:14 -0600 Message-ID: <1543859294-24259-1-git-send-email-erik.g.carrillo@intel.com> References: <1525469883-8342-1-git-send-email-erik.g.carrillo@intel.com> Cc: dev@dpdk.org To: jerin.jacob@caviumnetworks.com Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 8B37E4C93 for ; Mon, 3 Dec 2018 18:48:33 +0100 (CET) In-Reply-To: <1525469883-8342-1-git-send-email-erik.g.carrillo@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If timer events get dropped for some reason, the thread that launched producer and worker cores will never exit, because the deadlock check doesn't currently apply to the event timer adapter case. This commit fixes this. Fixes: d008f20bce23 ("app/eventdev: add event timer adapter as a producer") Signed-off-by: Erik Gabriel Carrillo Acked-by: Jerin Jacob --- v3: - Forgot to add Jerin's ack line. v2: - Add a fixline to commit message (Jerin) app/test-eventdev/test_perf_common.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/test_perf_common.c index 8618775..f99a6a6 100644 --- a/app/test-eventdev/test_perf_common.c +++ b/app/test-eventdev/test_perf_common.c @@ -327,7 +327,8 @@ perf_launch_lcores(struct evt_test *test, struct evt_options *opt, } if (new_cycles - dead_lock_cycles > dead_lock_sample && - opt->prod_type == EVT_PROD_TYPE_SYNT) { + (opt->prod_type == EVT_PROD_TYPE_SYNT || + opt->prod_type == EVT_PROD_TYPE_EVENT_TIMER_ADPTR)) { remaining = t->outstand_pkts - processed_pkts(t); if (dead_lock_remaining == remaining) { rte_event_dev_dump(opt->dev_id, stdout); -- 2.6.4