From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 07/11] crypto/dpaa2_sec: Add DPAA2_SEC PMD into build system Date: Mon, 09 Jan 2017 16:33:24 +0100 Message-ID: <1544143.B2rDg7MdQ1@xps13> References: <20161205125540.6419-1-akhil.goyal@nxp.com> <20161222201700.20020-1-akhil.goyal@nxp.com> <20161222201700.20020-8-akhil.goyal@nxp.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, declan.doherty@intel.com, pablo.de.lara.guarch@intel.com, john.mcnamara@intel.com, nhorman@tuxdriver.com To: Akhil Goyal , hemant.agrawal@nxp.com Return-path: Received: from mail-wm0-f52.google.com (mail-wm0-f52.google.com [74.125.82.52]) by dpdk.org (Postfix) with ESMTP id 9876D2C58 for ; Mon, 9 Jan 2017 16:33:26 +0100 (CET) Received: by mail-wm0-f52.google.com with SMTP id a197so101726676wmd.0 for ; Mon, 09 Jan 2017 07:33:26 -0800 (PST) In-Reply-To: <20161222201700.20020-8-akhil.goyal@nxp.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-12-23 01:46, Akhil Goyal: > +ifeq ($(CONFIG_RTE_LIBRTE_DPAA2_COMMON),y) > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += -lrte_pmd_dpaa2_sec > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += -lrte_pmd_dpaa2_qbman > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += -lrte_pmd_dpaa2_dpio > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += -lrte_pmd_dpaa2_pool > +_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_DPAA2_SEC) += -lrte_pmd_fslmcbus > +endif There are so much libs! We do not have even one commit per library in this patchset. Splitting patches would allow to better introduce them one by one with an explanation of the design and the role of each library.