From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH v3 1/3] dfs:add FUSE based filesystem for DPDK
Date: Sun, 16 Dec 2018 22:22:57 +0000
Message-ID: <1544998977.4766.10.camel@debian.org>
References: <20181216174604.91445-1-keith.wiles@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
To: Keith Wiles <keith.wiles@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com
 [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 8A1551B6DA
 for <dev@dpdk.org>; Sun, 16 Dec 2018 23:22:59 +0100 (CET)
Received: by mail-wr1-f66.google.com with SMTP id c14so10431183wrr.0
 for <dev@dpdk.org>; Sun, 16 Dec 2018 14:22:59 -0800 (PST)
In-Reply-To: <20181216174604.91445-1-keith.wiles@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Sun, 2018-12-16 at 11:46 -0600, Keith Wiles wrote:
> --- /dev/null
> +++ b/lib/librte_dfs/meson.build
> @@ -0,0 +1,47 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2018 Intel Corporation
> +
> +version =3D 1

You can leave the version out if it's 1, it's the default

> --- /dev/null
> +++ b/lib/librte_dfs/Makefile
> @@ -0,0 +1,51 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2018 Intel Corporation
> +
> +include $(RTE_SDK)/mk/rte.vars.mk
> +
> +# library name
> +LIB =3D librte_dfs.a
> +
> +CFLAGS +=3D $(WERROR_FLAGS) -I$(SRCDIR) -O3
> +CFLAGS +=3D -DALLOW_EXPERIMENTAL_API -D_FILE_OFFSET_BITS=3D64
> +CFLAGS +=3D -D_GNU_SOURCE
> +CFLAGS +=3D -I$(RTE_SDK)/drivers/bus/pci
> +LDLIBS +=3D -lrte_eal -lrte_mempool -lrte_hash -lrte_ethdev
> -lrte_utils
> +LDLIBS +=3D -lrte_ring -lrte_timer -lrte_rawdev -lrte_cryptodev
> +LDLIBS +=3D -lpthread
> +LDLIBS +=3D $(shell pkg-config --libs-only-l fuse3)
> +LDLIBS +=3D $(shell pkg-config --libs-only-l jansson)

Why --libs-only-l ? If the libraries are not installed in the canonical
path (eg: build-root-without-chroot) it will break as it won't use the
-L

--=20
Kind regards,
Luca Boccassi