From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v9 4/5] cryptodev: change burst API to be
	crypto op oriented
Date: Thu, 10 Mar 2016 17:03:04 +0100
Message-ID: <1546962.OW49KDJ4kE@xps13>
References: <1457617381-8296-1-git-send-email-fiona.trahe@intel.com>
 <1457624473-11138-5-git-send-email-fiona.trahe@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Fiona Trahe <fiona.trahe@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50])
 by dpdk.org (Postfix) with ESMTP id 7846728BF
 for <dev@dpdk.org>; Thu, 10 Mar 2016 17:04:47 +0100 (CET)
Received: by mail-wm0-f50.google.com with SMTP id l68so37125412wml.0
 for <dev@dpdk.org>; Thu, 10 Mar 2016 08:04:47 -0800 (PST)
In-Reply-To: <1457624473-11138-5-git-send-email-fiona.trahe@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-03-10 15:41, Fiona Trahe:
> lib/librte_cryptodev/rte_crypto_sym.h              | 374 ++++++------

Sorry there is another issue:

rte_crypto_sym.h:622: warning: argument 'op' of command @param is not found in the argument list of __rte_crypto_sym_op_attach_sym_session(struct rte_crypto_sym_op *sym_op, struct rte_cryptodev_sym_session *sess)
rte_crypto_sym.h:628: warning: The following parameters of __rte_crypto_sym_op_attach_sym_session(struct rte_crypto_sym_op *sym_op, struct rte_cryptodev_sym_session *sess) are not documented:
  parameter 'sym_op'
rte_crypto_sym.h:592: warning: unable to resolve reference to `rte_cryptodev_session_create' for \ref command

I've fixed it with the following changes:

                         * The length of the data pointed to by this field is
                         * set up for the session in the @ref
                         * rte_crypto_auth_xform structure as part of the @ref
-                        * rte_cryptodev_session_create function call.  This
-                        * length must not exceed 240 bytes.
+                        * rte_cryptodev_sym_session_create function call.
+                        * This length must not exceed 240 bytes.

 /**
  * Attach a session to a symmetric crypto operation
  *
- * @param      op      crypto operation
+ * @param      sym_op  crypto operation
  * @param      sess    cryptodev session
  */