From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [dpdk-stable] [PATCH] build: fix incorrect variable
 name in error message
Date: Thu, 10 Jan 2019 13:10:22 +0000
Message-ID: <1547125822.16085.3.camel@debian.org>
References: <20190110102919.53188-1-bruce.richardson@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: stable@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20190110102919.53188-1-bruce.richardson@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, 2019-01-10 at 10:29 +0000, Bruce Richardson wrote:
> The variable name in the error message had an extra '_' which caused
> an actual meson error when the message would otherwise be printed to
> give meaningful information about what was going wrong.
>=20
> Fixes: 203b61dc5e18 ("build: improve error message for missing
> dependency")
> CC: stable@dpdk.org
>=20
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> =C2=A0lib/meson.build | 2 +-
> =C2=A01 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/lib/meson.build b/lib/meson.build
> index a2dd52e17..93d7901d4 100644
> --- a/lib/meson.build
> +++ b/lib/meson.build
> @@ -79,7 +79,7 @@ foreach l:libraries
> =C2=A0			foreach d:deps
> =C2=A0				if not is_variable('shared_rte_' +
> d)
> =C2=A0					error('Missing dependency '
> + d +
> -						' for library ' +
> lib_name)
> +						' for library ' +
> libname)
> =C2=A0				endif
> =C2=A0				shared_deps +=3D
> [get_variable('shared_rte_' + d)]
> =C2=A0				static_deps +=3D
> [get_variable('static_rte_' + d)]

Acked-by: Luca Boccassi <bluca@debian.org>

--=20
Kind regards,
Luca Boccassi