From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH v3] build: use generic march on arm64 when
 using 'default' machine
Date: Fri, 11 Jan 2019 10:45:39 +0000
Message-ID: <1547203539.4501.7.camel@debian.org>
References: <20181224125627.25690-1-bluca@debian.org>
 <20190107141130.24360-1-bluca@debian.org>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: gavin.hu@arm.com, viktorin@rehivetech.com, jerinj@marvell.com,
 stable@dpdk.org
To: dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20190107141130.24360-1-bluca@debian.org>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, 2019-01-07 at 14:11 +0000, Luca Boccassi wrote:
> When building for generic distribution we need a stable baseline
> architecture, or depending on the build worker the result will vary.
>=20
> Force the default flags if the user explicitly sets machine=3Ddefault
> at configuration time.
>=20
> Fixes: b1d48c41189a ("build: support ARM with meson")
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Luca Boccassi <bluca@debian.org>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> v2: fix typo in commit message, remove variable used only once
> v3: put back temporary variable, as "machine" gets overwritten
> =C2=A0=C2=A0=C2=A0=C2=A0by the function and loses the original value befo=
re we need
> =C2=A0=C2=A0=C2=A0=C2=A0it.
>=20
> =C2=A0config/arm/meson.build | 7 ++++++-
> =C2=A01 file changed, 6 insertions(+), 1 deletion(-)
>=20
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index dae55d6b2..614139534 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -6,6 +6,7 @@
> =C2=A0march_opt =3D '-march=3D@0@'.format(machine)
> =C2=A0
> =C2=A0arm_force_native_march =3D false
> +arm_force_default_march =3D (machine =3D=3D 'default')
> =C2=A0
> =C2=A0machine_args_generic =3D [
> =C2=A0	['default', ['-march=3Darmv8-a+crc+crypto']],
> @@ -105,7 +106,11 @@ else
> =C2=A0	cmd_generic =3D ['generic', '', '', 'default', '']
> =C2=A0	cmd_output =3D cmd_generic # Set generic by default
> =C2=A0	machine_args =3D [] # Clear previous machine args
> -	if not meson.is_cross_build()
> +	if arm_force_default_march and not meson.is_cross_build()
> +		machine =3D impl_generic
> +		cmd_output =3D cmd_generic
> +		impl_pn =3D 'default'
> +	elif not meson.is_cross_build()
> =C2=A0		# The script returns ['Implementer', 'Variant',
> 'Architecture',
> =C2=A0		# 'Primary Part number', 'Revision']
> =C2=A0		detect_vendor =3D find_program(join_paths(

Any chance for a quick review from the arm maintainers/devs? Thanks!

--=20
Kind regards,
Luca Boccassi