From mboxrd@z Thu Jan  1 00:00:00 1970
From: Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH v2 3/3] build: bump minimum Meson to 0.47.1
 and use dependency() for libbsd
Date: Fri, 11 Jan 2019 15:04:38 +0000
Message-ID: <1547219078.4501.16.camel@debian.org>
References: <20190103175725.5836-1-bluca@debian.org>
 <20190111123809.8789-1-bluca@debian.org>
 <20190111123809.8789-3-bluca@debian.org>
 <20190111142700.GB15912@bricha3-MOBL.ger.corp.intel.com>
 <20190111143022.GC15912@bricha3-MOBL.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com
 [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id DB3E31BC00
 for <dev@dpdk.org>; Fri, 11 Jan 2019 16:04:40 +0100 (CET)
Received: by mail-wr1-f68.google.com with SMTP id p4so15530827wrt.7
 for <dev@dpdk.org>; Fri, 11 Jan 2019 07:04:40 -0800 (PST)
In-Reply-To: <20190111143022.GC15912@bricha3-MOBL.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, 2019-01-11 at 14:30 +0000, Bruce Richardson wrote:
> On Fri, Jan 11, 2019 at 02:27:01PM +0000, Bruce Richardson wrote:
> > On Fri, Jan 11, 2019 at 12:38:09PM +0000, Luca Boccassi wrote:
> > > Move libbsd inclusion to librte_eal, so that all other libraries
> > > and
> > > PMDs will inherit it, and librte_cmdline which is built before
> > > librte_eal.
> > > Bump Meson dependency to 0.47.1, to avoid bug where the linker
> > > flag of
> > > the dependency gets replicated again and again.
> > >=20
> > > Signed-off-by: Luca Boccassi <bluca@debian.org>
> > > ---
> > > v2: bump meson minimum version to 0.47.1 to avoid meson bug, and
> > > move
> > > =C2=A0=C2=A0=C2=A0=C2=A0libbsd dependency to eal and cmdline
> > >=20
> > > =C2=A0config/meson.build=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0| 10 +++++-----
> > > =C2=A0lib/librte_cmdline/meson.build |=C2=A0=C2=A04 ++++
> > > =C2=A0lib/librte_eal/meson.build=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=A0=
=C2=A03 +++
> > > =C2=A0meson.build=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0|=C2=
=A0=C2=A02 +-
> > > =C2=A04 files changed, 13 insertions(+), 6 deletions(-)
> > >=20
> >=20
> > There are some meson version checks in the code that can be removed
> > as
> > part of this change:
> >=20
> > $ git grep meson.version
> > drivers/meson.build:=C2=A0=C2=A0=C2=A0=C2=A0if
> > meson.version().version_compare('>=3D0.47')
> > kernel/linux/meson.build:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if
> > meson.version().version_compare('>=3D0.44')
> > kernel/linux/meson.build:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if
> > meson.version().version_compare('>=3D0.44')
> > meson.build:=C2=A0=C2=A0=C2=A0=C2=A0meson_version: '>=3D 0.41'
> > meson.build:if meson.version().version_compare('>=3D0.47')
> >=20
>=20
> Thinking on this more, I think the version bump to 0.47 should be
> done in a
> separate standalone patch at the start of this set. Then the other
> patches
> can be based on that.
>=20
> /Bruce

Ok, will remove those checks in v3 and move the bump to a different
patch. I'll put it second, as the first patch is really not related to
the version and it's stand-alone (and marked for stable), I was just
too lazy to do 2 series :-)

--=20
Kind regards,
Luca Boccassi