From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] examples/performance-thread: fix size of destination port ids in l3fwd-thread Date: Wed, 27 Apr 2016 17:25:04 +0200 Message-ID: <1547256.GDx29xVENn@xps13> References: <1461163527-7348-1-git-send-email-tomaszx.kulasek@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, ian.betts@intel.com, yuan.peng@intel.com To: Tomasz Kulasek Return-path: Received: from mail-wm0-f46.google.com (mail-wm0-f46.google.com [74.125.82.46]) by dpdk.org (Postfix) with ESMTP id 028142A1A for ; Wed, 27 Apr 2016 17:25:07 +0200 (CEST) Received: by mail-wm0-f46.google.com with SMTP id e201so44081866wme.0 for ; Wed, 27 Apr 2016 08:25:07 -0700 (PDT) In-Reply-To: <1461163527-7348-1-git-send-email-tomaszx.kulasek@intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-04-20 16:45, Tomasz Kulasek: > This patch uses similar approach for fix, like in commit 8353a36a9b4b > ("examples/l3fwd: fix size of destination port ids"), restoring 16 bit size > for destination port ids and doing necessary conversion from 32 to 16 bit > after lpm_lookupx4. > > Also fixes wrong logic in get_dst_port() on lpm path causing unpredictable > return value when ipv4/ipv6 lookup success, introduced in the same patch. The word "Also" means that you should write 2 patches :)