From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Boccassi Subject: Re: [EXT] Re: [PATCH v3] build: use generic march on arm64 when using 'default' machine Date: Mon, 14 Jan 2019 09:58:30 +0000 Message-ID: <1547459910.4501.26.camel@debian.org> References: <20181224125627.25690-1-bluca@debian.org> <20190107141130.24360-1-bluca@debian.org> <1547203539.4501.7.camel@debian.org> <1e16e55dacafcefe57861635a8a7c5d4729326fd.camel@marvell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: "gavin.hu@arm.com" , "stable@dpdk.org" , "viktorin@rehivetech.com" , "bruce.richardson@intel.com" To: Jerin Jacob Kollanukkaran , "dev@dpdk.org" Return-path: In-Reply-To: <1e16e55dacafcefe57861635a8a7c5d4729326fd.camel@marvell.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, 2019-01-14 at 08:09 +0000, Jerin Jacob Kollanukkaran wrote: > On Fri, 2019-01-11 at 10:45 +0000, Luca Boccassi wrote: > > External Email > >=20 > > ------------------------------------------------------------------- > > --- > > On Mon, 2019-01-07 at 14:11 +0000, Luca Boccassi wrote: > > > When building for generic distribution we need a stable baseline > > > architecture, or depending on the build worker the result will > > > vary. > > >=20 > > > Force the default flags if the user explicitly sets > > > machine=3Ddefault > > > at configuration time. > > >=20 > > > Fixes: b1d48c41189a ("build: support ARM with meson") > > > Cc: stable@dpdk.org > > >=20 > > > Signed-off-by: Luca Boccassi > > > Acked-by: Bruce Richardson > > > --- > > > v2: fix typo in commit message, remove variable used only once > > > v3: put back temporary variable, as "machine" gets overwritten > > > =C2=A0=C2=A0=C2=A0=C2=A0by the function and loses the original value = before we need > > > =C2=A0=C2=A0=C2=A0=C2=A0it. > > >=20 > > > =C2=A0config/arm/meson.build | 7 ++++++- > > > =C2=A01 file changed, 6 insertions(+), 1 deletion(-) > > >=20 > > > diff --git a/config/arm/meson.build b/config/arm/meson.build > > > index dae55d6b2..614139534 100644 > > > --- a/config/arm/meson.build > > > +++ b/config/arm/meson.build > > > @@ -6,6 +6,7 @@ > > > =C2=A0march_opt =3D '-march=3D@0@'.format(machine) > > > =C2=A0 > > > =C2=A0arm_force_native_march =3D false > > > +arm_force_default_march =3D (machine =3D=3D 'default') > > > =C2=A0 > > > =C2=A0machine_args_generic =3D [ > > > =C2=A0 ['default', ['-march=3Darmv8-a+crc+crypto']], > > > @@ -105,7 +106,11 @@ else > > > =C2=A0 cmd_generic =3D ['generic', '', '', 'default', ''] > > > =C2=A0 cmd_output =3D cmd_generic # Set generic by default > > > =C2=A0 machine_args =3D [] # Clear previous machine args > > > - if not meson.is_cross_build() > > > + if arm_force_default_march and not > > > meson.is_cross_build() > > > + machine =3D impl_generic > > > + cmd_output =3D cmd_generic > > > + impl_pn =3D 'default' > > > + elif not meson.is_cross_build() > > > =C2=A0 # The script returns ['Implementer', 'Variant', > > > 'Architecture', > > > =C2=A0 # 'Primary Part number', 'Revision'] > > > =C2=A0 detect_vendor =3D find_program(join_paths( > >=20 > > Any chance for a quick review from the arm maintainers/devs? > > Thanks! >=20 > Looks good. >=20 > Could you please document the procedure to build generic image some > where in the DPDK documentation. >=20 > I guess the procedure will be same for x86 and arm64. Right? The "machine" meson option is already described in meson_options.txt, is that enough? --=20 Kind regards, Luca Boccassi