From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konstantin Ananyev Subject: [PATCH] ipsec: fix invalid assert condition Date: Mon, 14 Jan 2019 12:07:39 +0000 Message-ID: <1547467659-15812-1-git-send-email-konstantin.ananyev@intel.com> Cc: akhil.goyal@nxp.com, pablo.de.lara.guarch@intel.com, ferruh.yigit@intel.com, Konstantin Ananyev To: dev@dpdk.org Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 92A1D4C6C for ; Mon, 14 Jan 2019 13:07:45 +0100 (CET) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" fix invalid RTE_ASSERT condition in rsn_update_finish() Fixes: c0308cd89554 ("ipsec: rework SA replay window/SQN for MT environment") Reported-by: Ferruh Yigit Signed-off-by: Konstantin Ananyev --- lib/librte_ipsec/ipsec_sqn.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_ipsec/ipsec_sqn.h b/lib/librte_ipsec/ipsec_sqn.h index 7de10bef5..a3ae7e2de 100644 --- a/lib/librte_ipsec/ipsec_sqn.h +++ b/lib/librte_ipsec/ipsec_sqn.h @@ -333,7 +333,7 @@ rsn_update_finish(struct rte_ipsec_sa *sa, struct replay_sqn *rsn) n = sa->sqn.inb.wridx; RTE_ASSERT(n != sa->sqn.inb.rdidx); - RTE_ASSERT(rsn - sa->sqn.inb.rsn == n); + RTE_ASSERT(rsn == sa->sqn.inb.rsn[n]); rte_rwlock_write_unlock(&rsn->rwl); sa->sqn.inb.rdidx = n; -- 2.17.1