From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 7/7] app/testpmd: rework for displaying different size of RX descriptors Date: Mon, 23 Jun 2014 17:43:41 +0200 Message-ID: <1548077.iev3PggAHf@xps13> References: <1403528231-4099-1-git-send-email-helin.zhang@intel.com> <1403528231-4099-8-git-send-email-helin.zhang@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Helin Zhang Return-path: In-Reply-To: <1403528231-4099-8-git-send-email-helin.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" Hi Helin, Thanks for this new patchset version. 2014-06-23 20:57, Helin Zhang: > i40e supports 16 and 32 bytes RX descriptors which can be configured. > It needs to check the driver type and the configuration to determine > if 16 or 32 bytes RX descriptors is being used, for reading and > displaying the different sizes of RX descriptors. > > Signed-off-by: Helin Zhang > Acked-by: Jing Chen > Acked-by: Cunming Liang Just before applying theses patches, I checked with checkpatch.pl which warned me about this: > + ring_rxd_display_dword(rte_le_to_cpu_64(\ > + ring[desc_id].lo_dword)); > + ring_rxd_display_dword(rte_le_to_cpu_64(\ > + ring[desc_id].hi_dword)); > + ring_rxd_display_dword(rte_le_to_cpu_64(\ > + ring[desc_id].resv1)); > + ring_rxd_display_dword(rte_le_to_cpu_64(\ > + ring[desc_id].resv2)); WARNING:LINE_CONTINUATIONS: Avoid unnecessary line continuations Could you remove it please? Thanks -- Thomas