From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] examples/kni: fix crash while handling userspace request Date: Thu, 17 Jan 2019 23:48:25 +0100 Message-ID: <15486437.2BuXh0EO9Z@xps> References: <20190115172802.72238-1-ferruh.yigit@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, "Phil Yang (Arm Technology China)" , "stable@dpdk.org" , "he.qiao17@zte.com.cn" , Igor Ryzhov , Dan Gora To: Ferruh Yigit Return-path: In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > > When KNI interface receives RTE_KNI_REQ_CFG_NETWORK_IF request, it > > stap/start the physical device which as a result of stop() can free all the mbufs in > > its queue. > > Meanwhile sample application continues to read from KNI interface queues and > > push into device queues. This simultaneous access may cause a crash, crash log > > can be found at defect description. > > > > As a solution KNI sample application can do the proper synchronization, and > > stop transfer between KNI interface and physical interface while physical device > > stop/started. > > > > Bugzilla ID: 116 > > Fixes: 3fc5ca2f6352 ("kni: initial import") > > Cc: stable@dpdk.org > > > > Signed-off-by: Ferruh Yigit > > Acked-by: Phil Yang Applied, thanks