From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] net/failsafe: fix build error on BSD 10 /
	GCC 4.8
Date: Thu, 20 Jul 2017 18:32:11 +0300
Message-ID: <1549179.tPcfIyeouT@xps>
References: <c74e5301361f6d326e5f2eac32e5d12732168ed6.1500553652.git.gaetan.rivet@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Gaetan Rivet <gaetan.rivet@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 16E9B29C8
 for <dev@dpdk.org>; Thu, 20 Jul 2017 17:32:14 +0200 (CEST)
In-Reply-To: <c74e5301361f6d326e5f2eac32e5d12732168ed6.1500553652.git.gaetan.rivet@6wind.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

20/07/2017 15:27, Gaetan Rivet:
> ctype.h is not compilable in BSD 10 on GCC 4.8 in C11 mode.
> 
> == Build drivers/net/failsafe
>   CC failsafe.o
> In file included from /usr/include/_ctype.h:94:0,
>                  from /usr/include/ctype.h:46,
>                  from /root/dpdk.org/build/include/rte_common.h:50,
>                  from /root/dpdk.org/build/include/rte_memory.h:57,
>                  from /root/dpdk.org/build/include/rte_malloc.h:45,
>                  from /root/dpdk.org/drivers/net/failsafe/failsafe.c:35:
> /usr/include/runetype.h:92:22: error: expected '=', ',', ';', 'asm' or
> '__attribute__' before 'const'
>  extern _Thread_local const _RuneLocale *_ThreadRuneLocale;
>                       ^
> /usr/include/runetype.h: In function '__getCurrentRuneLocale':
> /usr/include/runetype.h:96:6: error: '_ThreadRuneLocale' undeclareds
> (first use in this function)
>   if (_ThreadRuneLocale)
>       ^
> /usr/include/runetype.h:96:6: note: each undeclared identifier is reported
> only once for each function it appears in
> /root/dpdk.org/mk/internal/rte.compile-pre.mk:138: recipe for target
> 'failsafe.o' failed
> 
> The fix is to put GCC in gnu99 mode instead.
> 
> Fixes: a46f8d584eb8 ("net/failsafe: add fail-safe PMD")
> 
> Signed-off-by: Gaetan Rivet <gaetan.rivet@6wind.com>

Applied, thanks