From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anoob Joseph Subject: [PATCH] lib/cryptodev: fix driver name comparison Date: Mon, 4 Feb 2019 11:26:08 +0000 Message-ID: <1549279528-10397-1-git-send-email-anoobj@marvell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: Anoob Joseph , Jerin Jacob Kollanukkaran , Narayana Prasad Raju Athreya , "dev@dpdk.org" , Ankur Dwivedi To: Akhil Goyal , Declan Doherty , Pablo de Lara Return-path: Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 7284A5681 for ; Mon, 4 Feb 2019 12:26:15 +0100 (CET) Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The string compare to the length of driver name might give false positives when there are drivers with similar names (one being the subset of another). Following is such a naming which could result in false positive. 1. crypto_driver 2. crypto_driver1 When strncmp with len =3D strlen("crypto_driver") is done, it could give a false positive when compared against "crypto_driver1". Fixes: d11b0f30df88 ("cryptodev: introduce API and framework for crypto dev= ices") Signed-off-by: Ankur Dwivedi Signed-off-by: Anoob Joseph --- lib/librte_cryptodev/rte_cryptodev.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/lib/librte_cryptodev/rte_cryptodev.c b/lib/librte_cryptodev/rt= e_cryptodev.c index 7009735..b743c60 100644 --- a/lib/librte_cryptodev/rte_cryptodev.c +++ b/lib/librte_cryptodev/rte_cryptodev.c @@ -510,7 +510,8 @@ rte_cryptodev_pmd_get_named_dev(const char *name) dev =3D &cryptodev_globals.devs[i]; =20 if ((dev->attached =3D=3D RTE_CRYPTODEV_ATTACHED) && - (strcmp(dev->data->name, name) =3D=3D 0)) + (strncmp(dev->data->name, name, + RTE_CRYPTODEV_NAME_MAX_LEN) =3D=3D 0)) return dev; } =20 @@ -542,8 +543,8 @@ rte_cryptodev_get_dev_id(const char *name) return -1; =20 for (i =3D 0; i < cryptodev_globals.nb_devs; i++) - if ((strcmp(cryptodev_globals.devs[i].data->name, name) - =3D=3D 0) && + if ((strncmp(cryptodev_globals.devs[i].data->name, name, + RTE_CRYPTODEV_NAME_MAX_LEN) =3D=3D 0) && (cryptodev_globals.devs[i].attached =3D=3D RTE_CRYPTODEV_ATTACHED)) return i; @@ -586,7 +587,7 @@ rte_cryptodev_devices_get(const char *driver_name, uint= 8_t *devices, =20 cmp =3D strncmp(devs[i].device->driver->name, driver_name, - strlen(driver_name)); + RTE_CRYPTODEV_NAME_MAX_LEN); =20 if (cmp =3D=3D 0) devices[count++] =3D devs[i].data->dev_id; @@ -1691,7 +1692,7 @@ rte_cryptodev_driver_id_get(const char *name) =20 TAILQ_FOREACH(driver, &cryptodev_driver_list, next) { driver_name =3D driver->driver->name; - if (strncmp(driver_name, name, strlen(driver_name)) =3D=3D 0) + if (strncmp(driver_name, name, RTE_CRYPTODEV_NAME_MAX_LEN) =3D=3D 0) return driver->id; } return -1; --=20 2.7.4