From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luca Boccassi Subject: Re: [PATCH] build: add option to override max ethports Date: Wed, 06 Feb 2019 17:10:06 +0000 Message-ID: <1549473006.22781.2.camel@debian.org> References: <20190131021858.5832-1-3chas3@gmail.com> <20190131093203.GD122080@bricha3-MOBL.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Cc: dev@dpdk.org To: Bruce Richardson , Chas Williams <3chas3@gmail.com> Return-path: Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 591EF1B42E for ; Wed, 6 Feb 2019 18:10:09 +0100 (CET) Received: by mail-wr1-f68.google.com with SMTP id z15so6395883wrn.1 for ; Wed, 06 Feb 2019 09:10:09 -0800 (PST) In-Reply-To: <20190131093203.GD122080@bricha3-MOBL.ger.corp.intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, 2019-01-31 at 09:32 +0000, Bruce Richardson wrote: > On Wed, Jan 30, 2019 at 09:18:58PM -0500, Chas Williams wrote: > > Allow users and packagers to override the default RTE_MAX_ETHPORTS. > > This adds a new meson option, max_ethports which defaults to the > > current value. > >=20 > > Signed-off-by: Chas Williams <3chas3@gmail.com> >=20 > Agree with the idea. Just one small comment below re alphabetical > order. >=20 > Otherwise: > Acked-by: Bruce Richardson >=20 > > --- > > =C2=A0config/meson.build=C2=A0=C2=A0| 1 + > > =C2=A0config/rte_config.h | 1 - > > =C2=A0meson_options.txt=C2=A0=C2=A0=C2=A0| 2 ++ > > =C2=A03 files changed, 3 insertions(+), 1 deletion(-) > >=20 > > diff --git a/config/meson.build b/config/meson.build > > index db32499b3..e59507065 100644 > > --- a/config/meson.build > > +++ b/config/meson.build > > @@ -103,6 +103,7 @@ endforeach > > =C2=A0# set other values pulled from the build options > > =C2=A0dpdk_conf.set('RTE_MAX_LCORE', get_option('max_lcores')) > > =C2=A0dpdk_conf.set('RTE_MAX_NUMA_NODES', get_option('max_numa_nodes')) > > +dpdk_conf.set('RTE_MAX_ETHPORTS', get_option('max_ethports')) > > =C2=A0dpdk_conf.set('RTE_LIBEAL_USE_HPET', get_option('use_hpet')) > > =C2=A0dpdk_conf.set('RTE_EAL_ALLOW_INV_SOCKET_ID', > > get_option('allow_invalid_socket_id')) > > =C2=A0# values which have defaults which may be overridden > > diff --git a/config/rte_config.h b/config/rte_config.h > > index d3732e953..7606f5d7b 100644 > > --- a/config/rte_config.h > > +++ b/config/rte_config.h > > @@ -51,7 +51,6 @@ > > =C2=A0#define RTE_PKTMBUF_HEADROOM 128 > > =C2=A0 > > =C2=A0/* ether defines */ > > -#define RTE_MAX_ETHPORTS 32 > > =C2=A0#define RTE_MAX_QUEUES_PER_PORT 1024 > > =C2=A0#define RTE_ETHDEV_QUEUE_STAT_CNTRS 16 > > =C2=A0#define RTE_ETHDEV_RXTX_CALLBACKS 1 > > diff --git a/meson_options.txt b/meson_options.txt > > index 574054597..e54eedc66 100644 > > --- a/meson_options.txt > > +++ b/meson_options.txt > > @@ -28,3 +28,5 @@ option('use_hpet', type: 'boolean', value: false, > > =C2=A0 description: 'use HPET timer in EAL') > > =C2=A0option('tests', type: 'boolean', value: true, > > =C2=A0 description: 'build unit tests') > > +option('max_ethports', type: 'string', value: '32', > > + description: 'maximum number of Ethernet devices in EAL') > > --=C2=A0 >=20 > We are trying to keep the options in alphabetical order, so this > setting > should be just before "max_lcores" rather than at the end. >=20 > Interestingly, I see that since 0.45 there is now the option of an > "integer" option type. We should probably switch to use that once we > bump > our minimum meson version. [Luca, perhaps another change for your > set?] > Ref: http://mesonbuild.com/Build-options.html#integers Sounds good, I've added this change in v6 of the series --=20 Kind regards, Luca Boccassi