From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] librte_pmd_bond: fix exported symbol versioning Date: Mon, 11 Jul 2016 14:58:53 +0200 Message-ID: <1549476.KsTX9tT3L4@xps13> References: <1467805145-24817-1-git-send-email-christian.ehrhardt@canonical.com> <1468236421-30752-1-git-send-email-christian.ehrhardt@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Eric Kinzie , dev@dpdk.org To: Christian Ehrhardt Return-path: Received: from mail-wm0-f45.google.com (mail-wm0-f45.google.com [74.125.82.45]) by dpdk.org (Postfix) with ESMTP id A66D42BBD for ; Mon, 11 Jul 2016 14:58:57 +0200 (CEST) Received: by mail-wm0-f45.google.com with SMTP id f126so88432190wma.1 for ; Mon, 11 Jul 2016 05:58:57 -0700 (PDT) In-Reply-To: <1468236421-30752-1-git-send-email-christian.ehrhardt@canonical.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-07-11 13:27, Christian Ehrhardt: > *update in v2* > - add missing changes in rte_eth_bond_8023ad.h > > The older versions of rte_eth_bond_8023ad_conf_get and > rte_eth_bond_8023ad_setup were available in the old way since 2.0 - at > least according to the map file. > > But versioning in the code was set to 16.04. > That breaks compatibility checks for 2.0 on that library. > > For example with the dpdk abi checker: > http://people.canonical.com/~paelzer/compat_report.html > > To fix, version the old symbols on the 2.0 version as they were > initially added to the map file. > > See http://people.canonical.com/~paelzer/compat_report.html > > Fixes: dc40f17a ("net/bonding: allow external state machine in mode 4") > > Signed-off-by: Christian Ehrhardt Applied, thanks