From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul M Stillwell Jr Subject: [PATCH 1/1] net/ice: faster bit check Date: Fri, 15 Feb 2019 09:50:59 -0800 Message-ID: <1550253059-168336-1-git-send-email-paul.m.stillwell.jr@intel.com> Cc: dev@dpdk.org, Jesse Brandeburg , Paul M Stillwell Jr To: qi.z.zhang@intel.com Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 07DB11B4BD for ; Fri, 15 Feb 2019 18:51:32 +0100 (CET) List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Jesse Brandeburg Implement a slightly faster bit check, used for checking descriptors in the hot path. Signed-off-by: Jesse Brandeburg Signed-off-by: Paul M Stillwell Jr --- drivers/net/ice/ice_rxtx.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index c794ee8..7c82931 100644 --- a/drivers/net/ice/ice_rxtx.c +++ b/drivers/net/ice/ice_rxtx.c @@ -955,14 +955,13 @@ static inline uint64_t ice_rxd_status_to_pkt_flags(uint64_t qword) { - uint64_t flags; - - /* Check if RSS_HASH */ - flags = (((qword >> ICE_RX_DESC_STATUS_FLTSTAT_S) & - ICE_RX_DESC_FLTSTAT_RSS_HASH) == - ICE_RX_DESC_FLTSTAT_RSS_HASH) ? PKT_RX_RSS_HASH : 0; - - return flags; + static const uint64_t bitcheck = + (ICE_RX_DESC_FLTSTAT_RSS_HASH << ICE_RX_DESC_STATUS_FLTSTAT_S); + /* Check if RSS_HASH */ + if ((qword & bitcheck) == bitcheck) + return PKT_RX_RSS_HASH; + + return 0; } /* Rx L3/L4 checksum */ -- 1.8.3.1