From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] librte_ether:change rte_eth_mac_filter
	structure
Date: Fri, 31 Oct 2014 10:24:15 +0100
Message-ID: <1550663.1Z4EX83Uic@xps13>
References: <1414722382-14807-1-git-send-email-jijiang.liu@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org
To: Jijiang Liu <jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <1414722382-14807-1-git-send-email-jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2014-10-31 10:26, Jijiang Liu:
> As the filter type in i40e is defined enum type, so this patch changes
> the filter_type filed in the rte_eth_mac_filter for fixing the compilation
> error under ICC compiler. 

Commit log is wrong. It's not because of i40e, it's only an API problem.
But I know you mix i40e and generic API.

> Signed-off-by: Jijiang Liu <jijiang.liu-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

> --- a/lib/librte_ether/rte_eth_ctrl.h
> +++ b/lib/librte_ether/rte_eth_ctrl.h
> @@ -91,7 +91,7 @@ enum rte_mac_filter_type {
>  struct rte_eth_mac_filter {
>  	uint8_t is_vf; /**< 1 for VF, 0 for port dev */
>  	uint16_t dst_id; /**<VF ID, available when is_vf is 1*/
> -	uint16_t filter_type; /**< MAC filter type */
> +	enum rte_mac_filter_type filter_type; /**< MAC filter type */
>  	struct ether_addr mac_addr;
>  };

I didn't catch this error during my review. That's why we need more eyes to
carefully review patches.

Acked and applied

Thanks
-- 
Thomas