From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2 1/3] lib/librte_port: enable file descriptor port support Date: Fri, 14 Oct 2016 17:08:08 +0200 Message-ID: <1551628.WMOZ8qHgAT@xps13> References: <1470432064-59047-1-git-send-email-jasvinder.singh@intel.com> <8534270.5teDzHbgep@xps13> <3EB4FA525960D640B5BDFFD6A3D8912647A91878@IRSMSX108.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: "Singh, Jasvinder" , dev@dpdk.org To: "Dumitrescu, Cristian" Return-path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 62E1B231C for ; Fri, 14 Oct 2016 17:08:10 +0200 (CEST) Received: by mail-wm0-f53.google.com with SMTP id d128so3202597wmf.1 for ; Fri, 14 Oct 2016 08:08:10 -0700 (PDT) In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D8912647A91878@IRSMSX108.ger.corp.intel.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2016-10-12 20:44, Dumitrescu, Cristian: > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > This patchset was probably not tested as it does not compile. > > And it could be useless if a TAP PMD is integrated. > > I suggest to wait 17.02 cycle and see. > > This patch was tested by me and Jasvinder as well and it works brilliantly. > > We did not enable stats when testing, will sort out the missing semicolon issue in the stats macros and resend v3 asap. This is a trivial issue, no need to wait for 17.02. So the stats were not tested. > This is not conflicting with TAP PMD, and as said the scope of this supersedes the TAP PMD. The v3 has been applied and it breaks FreeBSD compilation now. I felt it was not ready but you won with the words "it works brilliantly" ;) (sorry I have not resisted to make the joke)