From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] net/enic: add private API to set ingress
	VLAN rewrite mode
Date: Wed, 13 Mar 2019 21:36:07 +0100
Message-ID: <155267265.tCld3OmuaL@xps>
References: <20190305055659.3095-1-hyonkim@cisco.com>
 <20190305071134.21725-1-hyonkim@cisco.com>
 <399e1eeb-3c3f-ac73-03e9-2e37b2d8ef52@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: Andrew Rybchenko <arybchenko@solarflare.com>,
 Qi Zhang <qi.z.zhang@intel.com>, dev@dpdk.org, John Daley <johndale@cisco.com>,
 Shahaf Shuler <shahafs@mellanox.com>,
 Jerin Jacob <jerin.jacob@caviumnetworks.com>,
 David Marchand <david.marchand@6wind.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 Stephen Hemminger <stephen@networkplumber.org>
To: Ferruh Yigit <ferruh.yigit@intel.com>, Hyong Youb Kim <hyonkim@cisco.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id A02AA2BD3
 for <dev@dpdk.org>; Wed, 13 Mar 2019 21:36:16 +0100 (CET)
In-Reply-To: <399e1eeb-3c3f-ac73-03e9-2e37b2d8ef52@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

13/03/2019 19:32, Ferruh Yigit:
> On 3/5/2019 7:11 AM, Hyong Youb Kim wrote:
> > The driver currently has a devarg to set the rewrite mode during
> > init. Some apps want to programatically set it after running
> > rte_eal_init() and finding that ports are VIC. Add a private function
> > to support such applications.
> 
> It is not good idea to have PMD specific APIs (although we already have some).
> 
> Specific to this case, as far as I can see it is to pass a config value and do
> the action related to it, what would you think having a generic key/value
> set/get API in ethdev for this? Similar to rawdev get_attr/set_attr [1]?
> 
> My concern is it may turn into something like ioctl with many things pushed to
> it, and cause possible duplication ...

Yes, it is clearly ioctl style.

Please could you explain more what is the rewrite mode?
Does it apply to the port or the queue?