* [dpdk-dev] [PATCH] doc: update ICE doc @ 2019-04-12 3:33 Wenzhuo Lu 2019-04-15 21:54 ` Rami Rosen 0 siblings, 1 reply; 6+ messages in thread From: Wenzhuo Lu @ 2019-04-12 3:33 UTC (permalink / raw) To: dev; +Cc: Wenzhuo Lu Update ICE document to describe a MDD event. Signed-off-by: Wenzhuo Lu <wenzhuo.lu@intel.com> --- doc/guides/nics/ice.rst | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/doc/guides/nics/ice.rst b/doc/guides/nics/ice.rst index 15c2766..666b1b2 100644 --- a/doc/guides/nics/ice.rst +++ b/doc/guides/nics/ice.rst @@ -82,6 +82,15 @@ are chosen based on 2 conditions. If any not supported features are used, ICE vector PMD is disabled and the normal paths are chosen. +Malicious driver detection (MDD) +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ + +It's not appropriate to send a packet, if this packet's destination MAC address +is just this port's MAC address. If SW tries to send such packets, HW will +report a MDD event and drop the packets. + +The APPs based on DPDK should avoid providing such packets. + Sample Application Notes ------------------------ -- 1.9.3 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: update ICE doc 2019-04-12 3:33 [dpdk-dev] [PATCH] doc: update ICE doc Wenzhuo Lu @ 2019-04-15 21:54 ` Rami Rosen 2019-04-16 4:39 ` Lu, Wenzhuo 0 siblings, 1 reply; 6+ messages in thread From: Rami Rosen @ 2019-04-15 21:54 UTC (permalink / raw) To: Wenzhuo Lu; +Cc: dev Hi, In I40E DPDK nic guide, https://doc.dpdk.org/guides/nics/i40e.html, MDD does not appear. In IXGBE DPDK nic guide, https://doc.dpdk.org/guides/nics/ixgbe.html, MDD appears, but in the known issues section. I think MDD is supported on both. just wonder, for the sake of consistency, is it worth to add such a section also for these nics ? Other than that, Acked-by: Rami Rosen <ramirose@gmail.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: update ICE doc 2019-04-15 21:54 ` Rami Rosen @ 2019-04-16 4:39 ` Lu, Wenzhuo 2019-04-16 7:59 ` Rami Rosen 2019-04-23 3:31 ` Zhang, Qi Z 0 siblings, 2 replies; 6+ messages in thread From: Lu, Wenzhuo @ 2019-04-16 4:39 UTC (permalink / raw) To: Rami Rosen; +Cc: dev@dpdk.org Hi Rami, From: Rami Rosen [mailto:ramirose@gmail.com] Sent: Tuesday, April 16, 2019 5:55 AM To: Lu, Wenzhuo <wenzhuo.lu@intel.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] doc: update ICE doc Hi, In I40E DPDK nic guide, https://doc.dpdk.org/guides/nics/i40e.html, MDD does not appear. [Wenzhuo] As I know, this feature is not supported by i40e. I40e can send such packets. That’s why we want to mentions this different behavior for ice. In IXGBE DPDK nic guide, https://doc.dpdk.org/guides/nics/ixgbe.html, MDD appears, but in the known issues section. [Wenzhuo] Actually, for ixgbe, we want to mention MDD as a limitation (the same section as known issue). Because it’s more like our driver’s robust is not so strong. We have to ask the APP to provide the right L2/L3 length. (The reason is it’s not effective to let the driver inspect the packet to get the right length.) But this ice behavior is more like a feature. To my opinion, it’s reasonable to drop such packets. That’s why I put it in the feature section. I think MDD is supported on both. just wonder, for the sake of consistency, is it worth to add such a section also for these nics ? Other than that, Acked-by: Rami Rosen <ramirose@gmail.com<mailto:ramirose@gmail.com>> ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: update ICE doc 2019-04-16 4:39 ` Lu, Wenzhuo @ 2019-04-16 7:59 ` Rami Rosen 2019-04-17 5:16 ` Lu, Wenzhuo 2019-04-23 3:31 ` Zhang, Qi Z 1 sibling, 1 reply; 6+ messages in thread From: Rami Rosen @ 2019-04-16 7:59 UTC (permalink / raw) To: Lu, Wenzhuo; +Cc: dev@dpdk.org Hi, Wenzhuo, Regarding MDD for I40E, I am basing this on what I saw on the web regarding MDD on I40E: https://lists.osuosl.org/pipermail/intel-wired-lan/Week-of-Mon-20170925/010131.html https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1772675 https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1723127 and more. Regards, Rami Rosen ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: update ICE doc 2019-04-16 7:59 ` Rami Rosen @ 2019-04-17 5:16 ` Lu, Wenzhuo 0 siblings, 0 replies; 6+ messages in thread From: Lu, Wenzhuo @ 2019-04-17 5:16 UTC (permalink / raw) To: Rami Rosen; +Cc: dev@dpdk.org Hi Rami, From: Rami Rosen [mailto:ramirose@gmail.com] Sent: Tuesday, April 16, 2019 3:59 PM To: Lu, Wenzhuo <wenzhuo.lu@intel.com> Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH] doc: update ICE doc Hi, Wenzhuo, Regarding MDD for I40E, I am basing this on what I saw on the web regarding MDD on I40E: https://lists.osuosl.org/pipermail/intel-wired-lan/Week-of-Mon-20170925/010131.html https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1772675 https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1723127 and more. [Wenzhuo] Have to say this patch is only for ICE. I’d like to leave this question to our i40e maintainers. Regards, Rami Rosen ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: update ICE doc 2019-04-16 4:39 ` Lu, Wenzhuo 2019-04-16 7:59 ` Rami Rosen @ 2019-04-23 3:31 ` Zhang, Qi Z 1 sibling, 0 replies; 6+ messages in thread From: Zhang, Qi Z @ 2019-04-23 3:31 UTC (permalink / raw) To: Lu, Wenzhuo, Rami Rosen; +Cc: dev@dpdk.org > -----Original Message----- > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Lu, Wenzhuo > Sent: Tuesday, April 16, 2019 12:40 PM > To: Rami Rosen <ramirose@gmail.com> > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: update ICE doc > > Hi Rami, > > From: Rami Rosen [mailto:ramirose@gmail.com] > Sent: Tuesday, April 16, 2019 5:55 AM > To: Lu, Wenzhuo <wenzhuo.lu@intel.com> > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] doc: update ICE doc > > Hi, > In I40E DPDK nic guide, https://doc.dpdk.org/guides/nics/i40e.html, > MDD does not appear. > [Wenzhuo] As I know, this feature is not supported by i40e. I40e can send > such packets. That’s why we want to mentions this different behavior for > ice. > > In IXGBE DPDK nic guide, https://doc.dpdk.org/guides/nics/ixgbe.html, > MDD appears, but in the known issues section. > [Wenzhuo] Actually, for ixgbe, we want to mention MDD as a limitation > (the same section as known issue). Because it’s more like our driver’s > robust is not so strong. We have to ask the APP to provide the right L2/L3 > length. (The reason is it’s not effective to let the driver inspect the packet > to get the right length.) But this ice behavior is more like a feature. To my > opinion, it’s reasonable to drop such packets. That’s why I put it in the > feature section. > > I think MDD is supported on both. > > just wonder, for the sake of consistency, is it worth to add such a section > also for these nics ? > > Other than that, > > Acked-by: Rami Rosen > <ramirose@gmail.com<mailto:ramirose@gmail.com>> Applied to dpdk-next-net-intel. Thanks Qi ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-04-23 3:31 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-04-12 3:33 [dpdk-dev] [PATCH] doc: update ICE doc Wenzhuo Lu 2019-04-15 21:54 ` Rami Rosen 2019-04-16 4:39 ` Lu, Wenzhuo 2019-04-16 7:59 ` Rami Rosen 2019-04-17 5:16 ` Lu, Wenzhuo 2019-04-23 3:31 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).