From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] buildtools: fix build for some mktemp Date: Sat, 27 Oct 2018 02:05:16 +0200 Message-ID: <1555566.RdUPOnmJgc@xps> References: <20181026184248.78908-1-ferruh.yigit@intel.com> <2054335.yDqyzkpi5h@xps> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Ferruh Yigit Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 6E66D1F1C for ; Sat, 27 Oct 2018 02:05:12 +0200 (CEST) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/10/2018 01:53, Ferruh Yigit: > On 10/27/2018 12:47 AM, Thomas Monjalon wrote: > > 27/10/2018 02:38, Ferruh Yigit: > >> build error: > >> == Build drivers/net/tap > >> mktemp: cannot create temp file /tmp/dpdk.auto-config-h.sh.XXX.c: > >> Invalid argument > >> .../buildtools/auto-config-h.sh: line 86: : No such file or directory > >> .../drivers/net/tap/Makefile:55: recipe for target > >> 'tap_autoconf.h.new' failed > >> > >> Above error observed on Wind River Linux 8.0 > >> > >> `mktemp` command in that system has a restrictions to have X in > >> the template at the end and at least six of them. > >> > >> Complied to mktemp requirements and add -xc flag to compiler to say > >> `temp` file is a C file > >> > >> Fixes: ff37ca5d3773 ("devtools: use a common prefix for temporary files") > >> > >> Reported-by: Shuai Zhu > >> Signed-off-by: Ferruh Yigit > >> --- > >> v2: > >> * keep using mktemp, add -xc to compiler > >> --- > >> buildtools/auto-config-h.sh | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> --- a/buildtools/auto-config-h.sh > >> +++ b/buildtools/auto-config-h.sh > >> -temp=$(mktemp -t dpdk.${0##*/}.XXX.c) > >> +temp=$(mktemp -t dpdk.${0##*/}.c.XXXXXX) > > > > It looks OK for this script. > > > > Should we do the same kind of change for devtools/check-includes.sh? > > and devtools/cocci.sh? > > Not sure, this script is part of buildtool and required for build, so needs to > be compatible for various systems. Above are devtools and can use new mktemp. You mean nobody will use Wind River Linux 8.0 for developing? You are probably right :)