From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] lib/power: add turbo functions to version.map
Date: Mon, 02 Oct 2017 16:55:49 +0200
Message-ID: <1556159.HUIlaTtd6f@xps>
References: <1506946848-173847-1-git-send-email-david.hunt@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: David Hunt <david.hunt@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id CB31B1B245
 for <dev@dpdk.org>; Mon,  2 Oct 2017 16:55:51 +0200 (CEST)
In-Reply-To: <1506946848-173847-1-git-send-email-david.hunt@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,
I have some comments about the API scope and some formatting.

Suggested title:
	power: add turbo functions to map file

02/10/2017 14:20, David Hunt:
> allows vm_power_manager example to be built against shared libraries

Fixes: 94608a0f7f45 ("power: add per-core turbo boost API")

> Signed-off-by: David Hunt <david.hunt@intel.com>
[...]
> +DPDK_17.11 {
> +	global:
> +
> +	rte_power_acpi_turbo_status;

Is it really the function you want to expose?
rte_power_turbo_status seems more generic.

More comments about what is part of the API:
If you do not want to expose ACPI and VM implementations,
it should not be part of the rte_* include files.

> +	rte_power_freq_disable_turbo;
> +	rte_power_freq_enable_turbo;
> +};
> +

This is a trailing new line.