From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v2] devtools: fix symbol check for filename with space Date: Thu, 19 Jul 2018 14:09:47 +0200 Message-ID: <1556161.F30VP9S7cZ@xps> References: <20180718210609.32547-1-thomas@monjalon.net> <20180718212658.24756-1-thomas@monjalon.net> <20180719111427.GA20362@hmswarspite.think-freely.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org To: Neil Horman Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id D004B3195 for ; Thu, 19 Jul 2018 14:09:51 +0200 (CEST) In-Reply-To: <20180719111427.GA20362@hmswarspite.think-freely.org> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/07/2018 13:14, Neil Horman: > On Wed, Jul 18, 2018 at 11:26:58PM +0200, Thomas Monjalon wrote: > > If the patch filename or the temporary file path have a space > > in their name, the script check-symbol-change.sh does not work. > > The variables for the filenames must be enclosed in quotes > > in order to preserve spaces. > > > > Fixes: 4bec48184e33 ("devtools: add checks for ABI symbol addition") > > Cc: nhorman@tuxdriver.com > > > > Signed-off-by: Thomas Monjalon > > --- > > v2: one occurence of "$mapfile" was missed in v1 > I don't have any issue with this change, but the only way I see to introduce a > space into the tempfile name is to set $TMPDIR to '/path/with silly spaces' or > something simmilar. I think we discussed this before, but it would alsmot make > sense to, instead of quoting everything, instead specify -p ./ to ensure the > tempfile has no spaces. When I save patches from my inbox, the filename has some spaces. I think quoting variables is mandatory.