Re: [PATCH 0/6] Extensions to test-pmd

[Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>]

2014-05-16 09:55, Cyril Chemparathy:
> On 5/16/2014 7:22 AM, Thomas Monjalon wrote:
> > This is not the first time a new engine is added by copy/pasting the most
> > part of an existing engine. For instance, the "mac-retry" engine was
> > added by Intel as a copy/paste of the original "mac" one.
> > This is acceptable but not the perfect way to implement engines.
> > To address this issue, a new engine function could be introduced to setup
> > some parameters to be used by "packet_fwd" function. This way, similar
> > engines could be removed.
> 
> Agreed that it sucks to incessantly replicate code.  Maybe some of the
> packet_fwd code is common enough to bump into run_pkt_fwd_on_lcore()?
> Most of these forwarding modes have similar looking code to
> receive/transmit bursts and free the failed remnants of the burst.
> Could this common code be bumped up into run_pkt_fwd_on_lcore() maybe?

Not sure it fits into run_pkt_fwd_on_lcore() for all engines.
Feel free to suggest patches :)

-- 
Thomas