From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH] ixgbe: do not include CRC in Tx byte count
Date: Wed, 01 Apr 2015 09:45:02 +0200
Message-ID: <1556408.e2XOMCRvgs@xps13>
References: <2601191342CEEE43887BDE71AB977258214074F6@irsmsx105.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev-VfR2kkLFssw@public.gmane.org, Stephen Hemminger <shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org>
To: Stephen Hemminger <stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org>
Return-path: <dev-bounces-VfR2kkLFssw@public.gmane.org>
In-Reply-To: <2601191342CEEE43887BDE71AB977258214074F6-pww93C2UFcwu0RiL9chJVbfspsVTdybXVpNB7YpNyf8@public.gmane.org>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev-VfR2kkLFssw@public.gmane.org>
List-Help: <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request-VfR2kkLFssw@public.gmane.org?subject=subscribe>
Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org
Sender: "dev" <dev-bounces-VfR2kkLFssw@public.gmane.org>

2015-03-24 23:54, Ananyev, Konstantin:
> From: Stephen Hemminger [mailto:stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org]
> > On Mon, 23 Mar 2015 16:45:44 +0000
> > "Ananyev, Konstantin" <konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> wrote:
> > > From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org
> > > > From: Stephen Hemminger <shemming-43mecJUBy8ZBDgjK7y7TUQ@public.gmane.org>
> > > >
> > > > The ixgbe driver was including CRC in the transmit packet byte
> > > > count, but not for packets received.
> > > > This was notice when forwarding and
> > > > the number of bytes received was greater than the number of bytes transmitted
> > > > for the same number of packets. Make the driver behave like other
> > > > virtual devices and not include CRC in byte count. Use the same queue
> > > > counters already computed and used for Rx.
> > >
> > > About RX side stats - as I remember it depends to what value hw_stip_crc is set at configure().
> > > If hw_stip_crc==1, then, yes CRC bytes are not included into  QBRC value.
> > > I If hw_stip_crc==0, then CRC bytes are included into QBRC.
> > 
> > That is an additional bug!
> >   * CRC should never be included in the byte count.
> >     This is not how Linux or other drivers report byte count.
> 
> I don't have any strong opinion here...
> For me any method (with or without CRC) of counting bytes are ok, as long as this method is identical across all PMDs we support.
> Which makes we wonder, what approach other PMDs use? 
> 
> > 
> >   * the byte count must be symmetrical Rx == Tx
> > 
> > The Brocade router always set strip_crc to 1. So did not see the additional bug
> > of CRC being included in byte count.
> 
> Are you going to submit v2, to make Rx==Tx for both cases?

Any conclusion?
Without update, this patch is going to be dropped.