From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2 7/8] doc/qat: update PMD build section
Date: Fri, 10 Aug 2018 11:00:38 +0200
Message-ID: <1556861.lFMShj47WS@xps>
References: <1533820674-9507-1-git-send-email-fiona.trahe@intel.com>
 <3437470.R4aupjBKb7@xps>
 <348A99DA5F5B7549AA880327E580B4358960000B@IRSMSX101.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: "dev@dpdk.org" <dev@dpdk.org>, "De Lara Guarch,
 Pablo" <pablo.de.lara.guarch@intel.com>, "Jozwiak,
 TomaszX" <tomaszx.jozwiak@intel.com>
To: "Trahe, Fiona" <fiona.trahe@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 62D8DFEB
 for <dev@dpdk.org>; Fri, 10 Aug 2018 11:00:41 +0200 (CEST)
In-Reply-To: <348A99DA5F5B7549AA880327E580B4358960000B@IRSMSX101.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

10/08/2018 09:51, Trahe, Fiona:
> Hi Thomas,
> 
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> > 09/08/2018 18:50, Fiona Trahe:
> > > +Quick instructions for QAT compressdev PMD are as follows:
> > >
> > > +.. code-block:: console
> > > +
> > > +	cd to the top-level DPDK directory
> > > +	make defconfig
> > > +	make
> > 
> > This code block seems too much obvious.
> Just for completeness and to be helpful - save people wasting time looking for 
> a non-existent QAT comp config option which they'd probably do if following the snippet above it
> for QAT crypto where there is a need to change config. 

I don't understand.
There is nothing to change in the config, right?

> > > +.. _qat_kernel:
> > > +
> > > +Dependency on the QAT kernel driver
> > > +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > 
> > The anchor seems useless.
> > 
> It's used a few paragraphs above.

I don't find it in your patches.