From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH] eal: move compat includes to common meson
	file
Date: Wed, 09 Jan 2019 22:36:34 +0100
Message-ID: <1557339.2CBSiR8abE@xps>
References: <98ec658513d481f8d22c8b438cc3fedc4a718d3f.1547054251.git.anatoly.burakov@intel.com>
 <CAJFAV8xUjcBr8Hk-+Y2ZOY+as1KFu6U4ntxL_-2tNVLFs7s82A@mail.gmail.com>
 <20190109205159.GA12480@bricha3-MOBL.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: David Marchand <david.marchand@redhat.com>,
 Anatoly Burakov <anatoly.burakov@intel.com>, dev@dpdk.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com
 [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 858771B4D1
 for <dev@dpdk.org>; Wed,  9 Jan 2019 22:36:37 +0100 (CET)
In-Reply-To: <20190109205159.GA12480@bricha3-MOBL.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

09/01/2019 21:51, Bruce Richardson:
> On Wed, Jan 09, 2019 at 06:29:32PM +0100, David Marchand wrote:
> >    On Wed, Jan 9, 2019 at 6:18 PM Anatoly Burakov
> >    <[1]anatoly.burakov@intel.com> wrote:
> > 
> >      Currently, while EAL does depend on librte_compat as far as common
> >      meson build is concerned, for some reason the headers for that
> >      library are not added into the list of includes. This is fixed in
> >      Linuxapp-specific meson file, but is absent from FreeBSD meson file.
> >      This worked fine up until recently, when an rte_compat dependency
> >      was added to rte_log, which is a common header. Fix this issue by
> >      adding librte_compat includes to common EAL meson file.
> >      Fixes: 844514c73569 ("eal: build with meson")
> >      Fixes: a8499f65a1d1 ("log: add missing experimental tag")
> >      Cc: [2]bruce.richardson@intel.com
> >      Cc: [3]david.marchand@redhat.com
> >      Cc: [4]stable@dpdk.org
> >      Signed-off-by: Anatoly Burakov <[5]anatoly.burakov@intel.com>
> > 
> >    lgtm, thanks.
> >    Reviewed-by: David Marchand <[6]david.marchand@redhat.com>
> >    --
> >    David Marchand
> > 
> Agreed.
> One other point I'd make is that having compat as a separate library seems
> a little like overkill to me - it's just one header file! Is there a reason
> why we don't just move it into the EAL where everyone can use it without
> having to specify another dependency?

+1 for moving compat into EAL.