From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org,
mirots-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH] pcap: fix compilation error introduced by kvargs
Date: Wed, 19 Mar 2014 14:44:31 +0100 [thread overview]
Message-ID: <1559530.9fFZGPfV9j@xps13> (raw)
In-Reply-To: <1393797088-25730-1-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
02/03/2014 22:51, Olivier Matz :
> Due to a merge conflict between commits 4c745617a1 and 9d5752d80,
> rte_eth_pcap.c was not compiling with the following error:
>
> rte_eth_pcap.c: In function 'rte_pmd_init_internals':
> rte_eth_pcap.c:559:30: error: dereferencing pointer to incomplete type
> rte_eth_pcap.c:560:15: error: dereferencing pointer to incomplete type
> rte_eth_pcap.c:561:18: error: dereferencing pointer to incomplete type
> rte_eth_pcap.c:603:47: error: dereferencing pointer to incomplete type
> rte_eth_pcap.c: In function 'rte_pmd_pcap_init':
> rte_eth_pcap.c:732:73: error: 'dict' undeclared (first use in this
> function)
> rte_eth_pcap.c:732:73: note: each undeclared identifier is reported
> only once for each function it appears in
>
> This commit replaces "struct args_dict" by "struct rte_kvargs" to fix
> the compilation issue.
>
> By the way, it also removes the declaration of these functions from
> the header file as no other file in DPDK references one of them. It
> avoids to include <rte_kvargs.h> in rte_eth_pcap.h.
>
> Pointed-out-by: Meir Tseitlin <mirots-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Olivier Matz <olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
I missed it when applying the patches. Sorry for the inconvenience.
It's now acked and applied.
--
Thomas
prev parent reply other threads:[~2014-03-19 13:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-02 21:51 [PATCH] pcap: fix compilation error introduced by kvargs Olivier Matz
[not found] ` <1393797088-25730-1-git-send-email-olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
2014-03-19 13:44 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559530.9fFZGPfV9j@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=mirots-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=olivier.matz-pdR9zngts4EAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).